summaryrefslogtreecommitdiffstats
path: root/HACKING
diff options
context:
space:
mode:
authorFrank Ch. Eigler <fche@elastic.org>2010-03-03 10:09:21 -0500
committerFrank Ch. Eigler <fche@elastic.org>2010-03-03 10:09:21 -0500
commit2392877244da7bbcc2dba67abf506bfcf4908620 (patch)
treeb5fc2580122bb973687a0b9e06714df2f5f80913 /HACKING
parent9b06e18aef324786a88a0fbb61dcfdb369586e7f (diff)
downloadsystemtap-steved-2392877244da7bbcc2dba67abf506bfcf4908620.tar.gz
systemtap-steved-2392877244da7bbcc2dba67abf506bfcf4908620.tar.xz
systemtap-steved-2392877244da7bbcc2dba67abf506bfcf4908620.zip
HACKING: emphasize embedded-c testing
Diffstat (limited to 'HACKING')
-rw-r--r--HACKING13
1 files changed, 8 insertions, 5 deletions
diff --git a/HACKING b/HACKING
index 24986a9e..132794c8 100644
--- a/HACKING
+++ b/HACKING
@@ -96,11 +96,14 @@ the <systemtap@sources.redhat.com> mailing list.
Internal function, variable, probe identifiers should be prefixed
with "_" for extra uniqueness, and not documented in the man pages.
- Tapsets should come with a tests cases that provide good test coverage.
- Every alias definition should be tested for pass-2 correctness. Every
- embedded-C routine should be tested for pass-4 buildability and ideally
- pass-5 correctness. The platforms/architectures against which the tapset
- was tested should be published, and ideally asserted by code.
+ Tapsets should come with a tests cases that provide good test
+ coverage. Every alias definition should be tested for pass-2
+ correctness. Every embedded-C routine should be tested for pass-4
+ buildability. As they are a security hazard, every tapset
+ embedded-C routine should be pass-5 stress-tested for response to
+ erroneous inputs. This applies doubly to /* unprivileged */ ones.
+ The platforms/architectures against which the tapset was tested
+ should be published, and ideally asserted by code.
Embedded-C code should avoid making references to the runtime or
other code possibly generated by the translator. Embedded-C code that