summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorfche <fche>2006-05-03 15:27:57 +0000
committerfche <fche>2006-05-03 15:27:57 +0000
commite7cc2081ba76284010d4d569527237da0898b5c9 (patch)
tree044afaff8bc896dc4314194f932c6f3c211c3810
parentb5e09b8bb400e5bd51f5e353dad95d868d3756ab (diff)
downloadsystemtap-steved-e7cc2081ba76284010d4d569527237da0898b5c9.tar.gz
systemtap-steved-e7cc2081ba76284010d4d569527237da0898b5c9.tar.xz
systemtap-steved-e7cc2081ba76284010d4d569527237da0898b5c9.zip
2006-05-03 Frank Ch. Eigler <fche@elastic.org>
* context.stp, errno.stp: Note/eliminate some retval() duplication.
-rw-r--r--tapset/ChangeLog4
-rw-r--r--tapset/context.stp19
-rw-r--r--tapset/errno.stp2
3 files changed, 7 insertions, 18 deletions
diff --git a/tapset/ChangeLog b/tapset/ChangeLog
index 42f97b46..63a125fe 100644
--- a/tapset/ChangeLog
+++ b/tapset/ChangeLog
@@ -1,3 +1,7 @@
+2006-05-03 Frank Ch. Eigler <fche@elastic.org>
+
+ * context.stp, errno.stp: Note/eliminate some retval() duplication.
+
2006-04-27 Martin Hunt <hunt@redhat.com>
* endian.stp (set_endian): Remove "pure" to prevent
diff --git a/tapset/context.stp b/tapset/context.stp
index 221c853b..48ee423f 100644
--- a/tapset/context.stp
+++ b/tapset/context.stp
@@ -112,21 +112,4 @@ function target:long () %{ /* pure */
THIS->__retvalue = _stp_target;
%}
-function returnval:long () %{ /* pure */
- if (CONTEXT->regs) {
-#if defined (__i386__)
- THIS->__retvalue = CONTEXT->regs->eax;
-#elif defined (__x86_64__)
- THIS->__retvalue = CONTEXT->regs->rax;
-#elif defined (__powerpc64__)
- THIS->__retvalue = CONTEXT->regs->gpr[3];
-#elif defined (__ia64__)
- THIS->__retvalue = CONTEXT->regs->r8;
-#elif defined (__sparc64__)
- THIS->__retvalue = CONTEXT->regs->u_regs[UREG_RETPC];
-#else
- THIS->__retvalue = -1;
-#endif
- } else
- THIS->__retvalue = -1;
-%}
+function returnval () { return retval () } # deprecated
diff --git a/tapset/errno.stp b/tapset/errno.stp
index 10c4532e..70625d1c 100644
--- a/tapset/errno.stp
+++ b/tapset/errno.stp
@@ -355,6 +355,8 @@ function errno_str:string (err:long) %{ /* pure */
function returnstr:string (returnp:long) %{ /* pure */
long ret;
+ /* XXX: unfortunate duplication with return.stp:retval() */
+
if (CONTEXT->regs) {
#if defined (__i386__)
ret = CONTEXT->regs->eax;