diff options
| author | Frank Ch. Eigler <fche@elastic.org> | 2008-06-02 15:32:24 -0400 |
|---|---|---|
| committer | Frank Ch. Eigler <fche@elastic.org> | 2008-06-02 15:32:24 -0400 |
| commit | d2e5bc50742b66f6a8816c4036c6026726b87f01 (patch) | |
| tree | 102b296d148ba5dee4ebe501a80c96b80059567f | |
| parent | 93db086a1a595baf97142a8ea2d4f3bae537f306 (diff) | |
| download | systemtap-steved-d2e5bc50742b66f6a8816c4036c6026726b87f01.tar.gz systemtap-steved-d2e5bc50742b66f6a8816c4036c6026726b87f01.tar.xz systemtap-steved-d2e5bc50742b66f6a8816c4036c6026726b87f01.zip | |
PR6534: add a comment blurb explaining sufficiency UTS_RELEASE compile-time check
| -rw-r--r-- | translate.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/translate.cxx b/translate.cxx index 219e2c33..f411bd8f 100644 --- a/translate.cxx +++ b/translate.cxx @@ -1090,6 +1090,12 @@ c_unparser::emit_module_init () o->newline() << "{"; o->newline(1) << "const char* release = UTS_RELEASE;"; + // NB: This UTS_RELEASE compile-time macro directly checks only that + // the compile-time kbuild tree matches the compile-time debuginfo/etc. + // It does not check the run time kernel value. However, this is + // probably OK since the kbuild modversions system aims to prevent + // mismatches between kbuild and runtime versions at module-loading time. + // o->newline() << "const char* machine = UTS_MACHINE;"; // NB: We could compare UTS_MACHINE too, but on x86 it lies // (UTS_MACHINE=i386, but uname -m is i686). Sheesh. |