summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Wielaard <mjw@redhat.com>2009-10-15 21:55:16 +0200
committerMark Wielaard <mjw@redhat.com>2009-10-15 22:37:57 +0200
commit6179a370d89b073d19407ec3d29e5e890367582b (patch)
treef023e88276f8cfbf3510486ff59b58ead7f784ad
parentf8a493892377692c1c8f60c38ee05ac1fa77a8ed (diff)
downloadsystemtap-steved-6179a370d89b073d19407ec3d29e5e890367582b.tar.gz
systemtap-steved-6179a370d89b073d19407ec3d29e5e890367582b.tar.xz
systemtap-steved-6179a370d89b073d19407ec3d29e5e890367582b.zip
Fix transok/tval-opt.stp testcase. Pick diffent function and non-empty block.
This testcase succeeded just because the value being set couldn't be found. So the error message being compared was the same. Set -o pipefail to catch that case. On vta compiled kernels it failed because the optimizer turned { statement } into statement. So pick a function and argument which location can always be found and add an extra 'next' statement so the block isn't folded. * testsuite/transok/tval-opt.stp: Set -o pipefail. Add 'next' to make sure block isn't empty. Use "do_filp_open" and "mode".
-rwxr-xr-xtestsuite/transok/tval-opt.stp3
1 files changed, 2 insertions, 1 deletions
diff --git a/testsuite/transok/tval-opt.stp b/testsuite/transok/tval-opt.stp
index 76dcfd24..6c795a5d 100755
--- a/testsuite/transok/tval-opt.stp
+++ b/testsuite/transok/tval-opt.stp
@@ -1,8 +1,9 @@
#! /bin/sh
set -e
+set -o pipefail
-script='probe kernel.function("kbd_keycode") { if ($keycode==50) $keycode=49 }'
+script='probe kernel.function("do_filp_open") { if ($mode==50) $mode=49 next }'
s1=`stap -p3 -g -e "$script" | sum`
s2=`stap -p3 -g -u -e "$script" | sum`