diff options
| author | Josh Stone <jistone@redhat.com> | 2009-09-17 14:42:04 -0700 |
|---|---|---|
| committer | Josh Stone <jistone@redhat.com> | 2009-09-17 14:48:01 -0700 |
| commit | 597c982e513c9fef84e64e9aaef77cb736245096 (patch) | |
| tree | 638deaff0888fb79e776a776cfd8d7ec71191eb5 | |
| parent | 707e2bec52a319441497f684b1a62d7ed97e3eff (diff) | |
| download | systemtap-steved-597c982e513c9fef84e64e9aaef77cb736245096.tar.gz systemtap-steved-597c982e513c9fef84e64e9aaef77cb736245096.tar.xz systemtap-steved-597c982e513c9fef84e64e9aaef77cb736245096.zip | |
Remove temporaries in netdev.change_mac
As reported by dsmith, reusing temporary locals will prevent our
limited optimizer from eliminating code. I'm getting rid of these
particular locals altogether.
* tapset/networking.stp (netdev.change_mac): Don't write mac
intermediates into locals; just pass them directly to sprintf.
| -rw-r--r-- | tapset/networking.stp | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/tapset/networking.stp b/tapset/networking.stp index 0c9d8afb..4732a72d 100644 --- a/tapset/networking.stp +++ b/tapset/networking.stp @@ -236,22 +236,14 @@ probe netdev.change_mac mac_len = $dev->addr_len // Old MAC Address - zero = $dev->dev_addr[0] - one = $dev->dev_addr[1] - two = $dev->dev_addr[2] - three =$dev->dev_addr[3] - four = $dev->dev_addr[4] - five = $dev->dev_addr[5] old_mac = sprintf("%02x:%02x:%02x:%02x:%02x:%02x", - zero, one, two, three, four, five) + $dev->dev_addr[0], $dev->dev_addr[1], + $dev->dev_addr[2], $dev->dev_addr[3], + $dev->dev_addr[4], $dev->dev_addr[5]) // New MAC Address - zero = $sa->sa_data[0] - one = $sa->sa_data[1] - two = $sa->sa_data[2] - three =$sa->sa_data[3] - four =$sa->sa_data[4] - five = $sa->sa_data[5] new_mac = sprintf("%02x:%02x:%02x:%02x:%02x:%02x", - zero, one, two, three, four, five) + $sa->sa_data[0], $sa->sa_data[1], + $sa->sa_data[2], $sa->sa_data[3], + $sa->sa_data[4], $sa->sa_data[5]) } |