diff options
| author | Frank Ch. Eigler <fche@elastic.org> | 2009-09-08 17:32:26 -0400 |
|---|---|---|
| committer | Frank Ch. Eigler <fche@elastic.org> | 2009-09-08 20:36:52 -0400 |
| commit | 20b69eca3931d338b09134b9c1f5dee2c49ca55b (patch) | |
| tree | 41899b7dd6d980869d741dbf53286dfb3dd0742f | |
| parent | 7622ef6a5183220fa56dedabaeb8fa87b0e43919 (diff) | |
| download | systemtap-steved-20b69eca3931d338b09134b9c1f5dee2c49ca55b.tar.gz systemtap-steved-20b69eca3931d338b09134b9c1f5dee2c49ca55b.tar.xz systemtap-steved-20b69eca3931d338b09134b9c1f5dee2c49ca55b.zip | |
PR10575: emit KERN_ERRORs on transport control message failures
Suspecting that some kernel->user control messages may be getting
lost, let's more robustly log these occurrences.
* runtime/transport/control.c (_stp_ctl_send): printk(KERN_ERROR)
instead of ignoring errors.
| -rw-r--r-- | runtime/transport/control.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/runtime/transport/control.c b/runtime/transport/control.c index 925a6768..2b368320 100644 --- a/runtime/transport/control.c +++ b/runtime/transport/control.c @@ -173,6 +173,9 @@ static int _stp_ctl_send(int type, void *data, int len) msleep(5); if (err > 0) wake_up_interruptible(&_stp_ctl_wq); + else + // printk instead of _stp_error since an error here means our transport is suspect + printk(KERN_ERROR "ctl_send (type=%d len=%d) failed: %d\n", type, len, err); dbug_trans(1, "returning %d\n", err); return err; } |