summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorfche <fche>2005-11-08 17:02:13 +0000
committerfche <fche>2005-11-08 17:02:13 +0000
commit1dca31ba51b8d76ce950f81d5108f94dbf624c47 (patch)
tree48f82cc1276492acdd3e279b9585f52e2dbbe6b6
parentf75abd8ee3fb4b153ebd6c2758400fafdfd2ee6d (diff)
downloadsystemtap-steved-1dca31ba51b8d76ce950f81d5108f94dbf624c47.tar.gz
systemtap-steved-1dca31ba51b8d76ce950f81d5108f94dbf624c47.tar.xz
systemtap-steved-1dca31ba51b8d76ce950f81d5108f94dbf624c47.zip
2005-11-08 Frank Ch. Eigler <fche@redhat.com>
Patch from "Mao, Bibo" <bibo.mao@intel.com> * translate.cxx (mapvar::exists): Correct 64-bit type mismatch.
-rw-r--r--ChangeLog5
-rw-r--r--HACKING3
-rw-r--r--translate.cxx2
3 files changed, 8 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 0539598e..c2274e0c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2005-11-08 Frank Ch. Eigler <fche@redhat.com>
+ Patch from "Mao, Bibo" <bibo.mao@intel.com>
+ * translate.cxx (mapvar::exists): Correct 64-bit type mismatch.
+
+2005-11-08 Frank Ch. Eigler <fche@redhat.com>
+
* tapsets.cxx (blacklisted_p): Add blacklist for some .return
probes to kludge around bug #1345.
* tapset/system_calls.stp: Add some %( %? %) conditionals to
diff --git a/HACKING b/HACKING
index 116d6117..2be2fc0f 100644
--- a/HACKING
+++ b/HACKING
@@ -39,7 +39,8 @@ the <systemtap@sources.redhat.com> mailing list.
- test suites
As far as practicable, changes should be accompanied by test cases
- to prevent future regressions.
+ to prevent future regressions. Tests should be run on at least
+ x86, and ideally also on some 64-bit platform.
Tests that don't require probe execution should go into new or
modified files under /src/testsuite/, a simple automake-flavoured
diff --git a/translate.cxx b/translate.cxx
index 0c1ce84f..d3e9a492 100644
--- a/translate.cxx
+++ b/translate.cxx
@@ -471,7 +471,7 @@ struct mapvar
string exists (vector<tmpvar> const & indices) const
{
- return "(((int)" + call_prefix("get", indices) + ")) != 0)";
+ return "(((int64_t)" + call_prefix("get", indices) + ")) != 0)";
}
string get (vector<tmpvar> const & indices) const