Make project pyflakes clean.

Added both a tox test-env for pyflakes and fixed the current pyflakes errors.
This did actually fix a couple of bugs.

The CI team has started using pyflakes on its projects and also has started
using oslo for things, so ignoring pyflakes warnings on the oslo code was
starting to get old. However, additionally, pyflakes is pretty solid, so we
should maybe consider gating on it across the board. (% locals() is the
biggest thing that we do that it doesn't like)

Change-Id: Iac1ca62db301892b7863711162fcbc74807eb24f

1 files changed, 4 insertions, 0 deletions

diff --git a/tox.ini b/tox.ini
index 7f97a91..d7ecb96 100644
--- a/tox.ini
+++ b/tox.ini
@@ -27,3 +27,7 @@ commands = {posargs}
 deps = -r{toxinidir}/tools/pip-requires
        -r{toxinidir}/tools/test-requires
        -r{toxinidir}/tools/test-options
+
+[testenv:pyflakes]
+deps = pyflakes
+commands = pyflakes openstack setup.py update.py