summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorMatthew Treinish <treinish@linux.vnet.ibm.com>2013-02-11 16:50:37 -0500
committerMatthew Treinish <treinish@linux.vnet.ibm.com>2013-02-11 16:56:03 -0500
commit6a01a8c085bbb5f563490c000504d19f4d72dec0 (patch)
tree2fb33e9e42524e9680c6ed84125669de525abfa3 /tools
parente650657862b0d9c070f70fe078af56c55fb02e73 (diff)
downloadoslo-6a01a8c085bbb5f563490c000504d19f4d72dec0.tar.gz
oslo-6a01a8c085bbb5f563490c000504d19f4d72dec0.tar.xz
oslo-6a01a8c085bbb5f563490c000504d19f4d72dec0.zip
Cleanup docstring and print in install_venv_common
This commit cleans up usage in the docstring for: run_command_with_code() to be more explicit in the description of where the commands are being run. It also updates the prints to be consistent in the usage of venv vs virtualenv. These changes were recommended in the review for change: I68fe3449ed0fcc7fdfb84af2dcc77a39ebde7f01 Change-Id: I3cdb3d991503446d37c8fa6a3547585a4f8beb6a
Diffstat (limited to 'tools')
-rw-r--r--tools/install_venv_common.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/install_venv_common.py b/tools/install_venv_common.py
index 75e3302..00f73d7 100644
--- a/tools/install_venv_common.py
+++ b/tools/install_venv_common.py
@@ -58,7 +58,7 @@ class InstallVenv(object):
check_exit_code=True):
"""Runs a command in an out-of-process shell.
- Returns the output of that command. Working directory is ROOT.
+ Returns the output of that command. Working directory is self.root.
"""
if redirect_output:
stdout = subprocess.PIPE
@@ -101,7 +101,7 @@ class InstallVenv(object):
else:
self.run_command(['virtualenv', '-q', self.venv])
print 'done.'
- print 'Installing pip in virtualenv...',
+ print 'Installing pip in venv...',
if not self.run_command(['tools/with_venv.sh', 'easy_install',
'pip>1.0']).strip():
self.die("Failed to install pip.")