diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2013-05-20 13:14:32 +0100 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2013-05-20 13:46:14 +0100 |
| commit | ba849efe75f9ca267e03ca22e8647f140bbaaf66 (patch) | |
| tree | eb81f4428540f1ab5feeafae3da72f5c748796c2 /tests | |
| parent | 2d579dd3f311d3c5cb9aa1658d81488bb526b09c (diff) | |
| download | oslo-ba849efe75f9ca267e03ca22e8647f140bbaaf66.tar.gz oslo-ba849efe75f9ca267e03ca22e8647f140bbaaf66.tar.xz oslo-ba849efe75f9ca267e03ca22e8647f140bbaaf66.zip | |
Use mox object from moxstubout fixture
The moxstubout fixture creates a mox object which we can re-use in
tests.
It also ensures verify() is called, which it clearly wasn't in the
case of the qpid tests.
Change-Id: Ibf3326f18b160865012d40a5841b65438262c4df
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/rpc/test_qpid.py | 2 | ||||
| -rw-r--r-- | tests/unit/scheduler/test_base_filter.py | 3 | ||||
| -rw-r--r-- | tests/utils.py | 4 |
3 files changed, 3 insertions, 6 deletions
diff --git a/tests/unit/rpc/test_qpid.py b/tests/unit/rpc/test_qpid.py index 82cc119..1630ac4 100644 --- a/tests/unit/rpc/test_qpid.py +++ b/tests/unit/rpc/test_qpid.py @@ -69,7 +69,6 @@ class RpcQpidTestCase(utils.BaseTestCase): self.mock_session = None self.mock_sender = None self.mock_receiver = None - self.mox = mox.Mox() self.orig_connection = qpid.messaging.Connection self.orig_session = qpid.messaging.Session @@ -437,7 +436,6 @@ class RpcQpidTestCase(utils.BaseTestCase): if expect_failure: self.mock_session.next_receiver(timeout=mox.IsA(int)).AndRaise( qpid.messaging.exceptions.Empty()) - self.mock_receiver.fetch() self.mock_session.close() self.mock_connection.session().AndReturn(self.mock_session) else: diff --git a/tests/unit/scheduler/test_base_filter.py b/tests/unit/scheduler/test_base_filter.py index 65809ea..d66d84c 100644 --- a/tests/unit/scheduler/test_base_filter.py +++ b/tests/unit/scheduler/test_base_filter.py @@ -13,8 +13,6 @@ # See the License for the specific language governing permissions and # limitations under the License. -import mox - from openstack.common.scheduler import base_filter from tests import utils @@ -25,7 +23,6 @@ class TestBaseFilter(utils.BaseTestCase): def setUp(self): super(TestBaseFilter, self).setUp() self.filter = base_filter.BaseFilter() - self.mox = mox.Mox() def test_filter_one_is_called(self): filters = [1, 2, 3, 4] diff --git a/tests/utils.py b/tests/utils.py index c5c7c00..a23dd75 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -31,7 +31,9 @@ class BaseTestCase(testtools.TestCase): def setUp(self): super(BaseTestCase, self).setUp() - self.stubs = self.useFixture(moxstubout.MoxStubout()).stubs + moxfixture = self.useFixture(moxstubout.MoxStubout()) + self.mox = moxfixture.mox + self.stubs = moxfixture.stubs self.addCleanup(CONF.reset) self.useFixture(fixtures.FakeLogger('openstack.common')) self.useFixture(fixtures.Timeout(30, True)) |