diff options
| author | Dan Smith <danms@us.ibm.com> | 2013-01-03 11:23:30 -0800 |
|---|---|---|
| committer | Dan Smith <danms@us.ibm.com> | 2013-01-04 06:33:23 -0800 |
| commit | 09b341db792fa25fe67c560c65f278ce9c70957e (patch) | |
| tree | b413da61a70292c7b643304a501c53b83c99031c /tests | |
| parent | 0ccb03b37a74943430c2e81a3955a94d2c8136c0 (diff) | |
| download | oslo-09b341db792fa25fe67c560c65f278ce9c70957e.tar.gz oslo-09b341db792fa25fe67c560c65f278ce9c70957e.tar.xz oslo-09b341db792fa25fe67c560c65f278ce9c70957e.zip | |
Make time comparison functions accept strings
This patch makes is_older_than() and is_newer_than() accept
timestamps in string format, as returned from strtime().
Change-Id: I1dbf453cc08bd8aaeb4fee2491a1e8aa74f8bee3
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/test_timeutils.py | 38 |
1 files changed, 30 insertions, 8 deletions
diff --git a/tests/unit/test_timeutils.py b/tests/unit/test_timeutils.py index b5cd898..1407f29 100644 --- a/tests/unit/test_timeutils.py +++ b/tests/unit/test_timeutils.py @@ -65,26 +65,48 @@ class TimeUtilsTest(unittest.TestCase): t = timeutils.parse_strtime(s) self.assertEqual(orig_t, t) - def test_is_older_than(self): + def _test_is_older_than(self, fn): + strptime = datetime.datetime.strptime with mock.patch('datetime.datetime') as datetime_mock: datetime_mock.utcnow.return_value = self.skynet_self_aware_time - expect_true = timeutils.is_older_than(self.one_minute_before, 59) + datetime_mock.strptime = strptime + expect_true = timeutils.is_older_than(fn(self.one_minute_before), + 59) self.assertTrue(expect_true) - expect_false = timeutils.is_older_than(self.one_minute_before, 60) + expect_false = timeutils.is_older_than(fn(self.one_minute_before), + 60) self.assertFalse(expect_false) - expect_false = timeutils.is_older_than(self.one_minute_before, 61) + expect_false = timeutils.is_older_than(fn(self.one_minute_before), + 61) self.assertFalse(expect_false) - def test_is_newer_than(self): + def test_is_older_than_datetime(self): + self._test_is_older_than(lambda x: x) + + def test_is_older_than_str(self): + self._test_is_older_than(timeutils.strtime) + + def _test_is_newer_than(self, fn): + strptime = datetime.datetime.strptime with mock.patch('datetime.datetime') as datetime_mock: datetime_mock.utcnow.return_value = self.skynet_self_aware_time - expect_true = timeutils.is_newer_than(self.one_minute_after, 59) + datetime_mock.strptime = strptime + expect_true = timeutils.is_newer_than(fn(self.one_minute_after), + 59) self.assertTrue(expect_true) - expect_false = timeutils.is_newer_than(self.one_minute_after, 60) + expect_false = timeutils.is_newer_than(fn(self.one_minute_after), + 60) self.assertFalse(expect_false) - expect_false = timeutils.is_newer_than(self.one_minute_after, 61) + expect_false = timeutils.is_newer_than(fn(self.one_minute_after), + 61) self.assertFalse(expect_false) + def test_is_newer_than_datetime(self): + self._test_is_newer_than(lambda x: x) + + def test_is_newer_than_str(self): + self._test_is_newer_than(timeutils.strtime) + def test_utcnow_ts(self): skynet_self_aware_timestamp = 872835240 dt = datetime.datetime.utcfromtimestamp(skynet_self_aware_timestamp) |