diff options
| author | Zhongyue Luo <zhongyue.nah@intel.com> | 2013-05-10 23:15:08 +0800 |
|---|---|---|
| committer | Zhongyue Luo <zhongyue.nah@intel.com> | 2013-05-13 18:15:10 +0800 |
| commit | a51469326e84ed977ecc4e57fd3d46cdc21aa08f (patch) | |
| tree | a22f42c9bf362d06f43efd618579345f74a785cf /openstack/common/setup.py | |
| parent | 20379f2816774469287502cf857dc01a93ad1370 (diff) | |
| download | oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.tar.gz oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.tar.xz oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.zip | |
Removes len() on empty sequence evaluation
PEP8 suggestes, "For sequences, use the fact that empty sequences are false."
Change-Id: I4c600a7a6230a55328ee46f7c59f340f37abc18f
Diffstat (limited to 'openstack/common/setup.py')
| -rw-r--r-- | openstack/common/setup.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/openstack/common/setup.py b/openstack/common/setup.py index 03b0675..1b3a127 100644 --- a/openstack/common/setup.py +++ b/openstack/common/setup.py @@ -127,11 +127,9 @@ def _run_shell_command(cmd, throw_on_error=False): out = output.communicate() if output.returncode and throw_on_error: raise Exception("%s returned %d" % cmd, output.returncode) - if len(out) == 0: + if not out: return None - if len(out[0].strip()) == 0: - return None - return out[0].strip() + return out[0].strip() or None def _get_git_directory(): |