diff options
| author | Monty Taylor <mordred@inaugust.com> | 2012-11-21 10:53:18 -0800 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2012-11-28 17:05:36 +0000 |
| commit | cf705c59615fb68cdbfe664e7827e4a275a4a282 (patch) | |
| tree | f7d8a2f674acb0d4df9339f77f3511a123f7a525 /openstack/common/service.py | |
| parent | f10b956dd5b88b048c582cadc3c22ec5360521c9 (diff) | |
| download | oslo-cf705c59615fb68cdbfe664e7827e4a275a4a282.tar.gz oslo-cf705c59615fb68cdbfe664e7827e4a275a4a282.tar.xz oslo-cf705c59615fb68cdbfe664e7827e4a275a4a282.zip | |
Make project pyflakes clean.
Added both a tox test-env for pyflakes and fixed the current pyflakes errors.
This did actually fix a couple of bugs.
The CI team has started using pyflakes on its projects and also has started
using oslo for things, so ignoring pyflakes warnings on the oslo code was
starting to get old. However, additionally, pyflakes is pretty solid, so we
should maybe consider gating on it across the board. (% locals() is the
biggest thing that we do that it doesn't like)
Change-Id: Iac1ca62db301892b7863711162fcbc74807eb24f
Diffstat (limited to 'openstack/common/service.py')
| -rw-r--r-- | openstack/common/service.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/openstack/common/service.py b/openstack/common/service.py index 910a738..3186d56 100644 --- a/openstack/common/service.py +++ b/openstack/common/service.py @@ -36,6 +36,7 @@ from openstack.common.gettextutils import _ from openstack.common import log as logging from openstack.common import threadgroup + rpc = extras.try_import('openstack.common.rpc') CONF = cfg.CONF LOG = logging.getLogger(__name__) @@ -250,10 +251,12 @@ class ProcessLauncher(object): if os.WIFSIGNALED(status): sig = os.WTERMSIG(status) - LOG.info(_('Child %(pid)d killed by signal %(sig)d'), locals()) + LOG.info(_('Child %(pid)d killed by signal %(sig)d'), + dict(pid=pid, sig=sig)) else: code = os.WEXITSTATUS(status) - LOG.info(_('Child %(pid)d exited with status %(code)d'), locals()) + LOG.info(_('Child %(pid)s exited with status %(code)d'), + dict(pid=pid, code=code)) if pid not in self.children: LOG.warning(_('pid %d not in child list'), pid) |