summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRussell Bryant <rbryant@redhat.com>2012-01-31 14:48:12 -0500
committerRussell Bryant <rbryant@redhat.com>2012-01-31 14:52:55 -0500
commitd22b0210b0c4ef80b64531e6826985341e9af838 (patch)
tree98f5c13b5b607107c9724bd8aa33095226e18b0c
parentfe56d3c6ba27048a4d72dca7a9830061a551906c (diff)
Remove utils.runthis().
Fixes bug 884825. The bug was pointing out some unused variables noticed by pylint. utils.runthis() was only used in one place and doesn't really provide much value over utils.execute(), so just remove it. Change-Id: I3dcc34bd840a128418b58a8a66acb62adf3fc9cc
-rw-r--r--nova/crypto.py2
-rw-r--r--nova/utils.py5
2 files changed, 1 insertions, 6 deletions
diff --git a/nova/crypto.py b/nova/crypto.py
index 83d79964b..f2b522d09 100644
--- a/nova/crypto.py
+++ b/nova/crypto.py
@@ -119,7 +119,7 @@ def ensure_ca_filesystem():
if not os.path.exists(ca_dir):
os.makedirs(ca_dir)
os.chdir(ca_dir)
- utils.runthis(_("Generating root CA: %s"), "sh", genrootca_sh_path)
+ utils.execute("sh", genrootca_sh_path)
os.chdir(start)
diff --git a/nova/utils.py b/nova/utils.py
index 818dc2b73..791c63167 100644
--- a/nova/utils.py
+++ b/nova/utils.py
@@ -338,11 +338,6 @@ def debug(arg):
return arg
-def runthis(prompt, *cmd, **kwargs):
- LOG.debug(_('Running %s'), (' '.join(cmd)))
- rv, err = execute(*cmd, **kwargs)
-
-
def generate_uid(topic, size=8):
characters = '01234567890abcdefghijklmnopqrstuvwxyz'
choices = [random.choice(characters) for x in xrange(size)]