From d22b0210b0c4ef80b64531e6826985341e9af838 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Tue, 31 Jan 2012 14:48:12 -0500 Subject: Remove utils.runthis(). Fixes bug 884825. The bug was pointing out some unused variables noticed by pylint. utils.runthis() was only used in one place and doesn't really provide much value over utils.execute(), so just remove it. Change-Id: I3dcc34bd840a128418b58a8a66acb62adf3fc9cc --- nova/crypto.py | 2 +- nova/utils.py | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/nova/crypto.py b/nova/crypto.py index 83d79964b..f2b522d09 100644 --- a/nova/crypto.py +++ b/nova/crypto.py @@ -119,7 +119,7 @@ def ensure_ca_filesystem(): if not os.path.exists(ca_dir): os.makedirs(ca_dir) os.chdir(ca_dir) - utils.runthis(_("Generating root CA: %s"), "sh", genrootca_sh_path) + utils.execute("sh", genrootca_sh_path) os.chdir(start) diff --git a/nova/utils.py b/nova/utils.py index 818dc2b73..791c63167 100644 --- a/nova/utils.py +++ b/nova/utils.py @@ -338,11 +338,6 @@ def debug(arg): return arg -def runthis(prompt, *cmd, **kwargs): - LOG.debug(_('Running %s'), (' '.join(cmd))) - rv, err = execute(*cmd, **kwargs) - - def generate_uid(topic, size=8): characters = '01234567890abcdefghijklmnopqrstuvwxyz' choices = [random.choice(characters) for x in xrange(size)] -- cgit