diff options
author | neilbrown <neilbrown> | 2003-05-21 05:49:00 +0000 |
---|---|---|
committer | neilbrown <neilbrown> | 2003-05-21 05:49:00 +0000 |
commit | 77c32fa565d6af59cbeb8601e08efa9af6ef3d81 (patch) | |
tree | b998029eb2a4dfe05c7aaa16b3cfcaa27524b98c /utils | |
parent | 36b091949d42e2dfe125343b19961aaeb67b2322 (diff) | |
download | nfs-utils-77c32fa565d6af59cbeb8601e08efa9af6ef3d81.tar.gz nfs-utils-77c32fa565d6af59cbeb8601e08efa9af6ef3d81.tar.xz nfs-utils-77c32fa565d6af59cbeb8601e08efa9af6ef3d81.zip |
Define and use get_reliable_hostbyname
Diffstat (limited to 'utils')
-rw-r--r-- | utils/mountd/auth.c | 79 |
1 files changed, 13 insertions, 66 deletions
diff --git a/utils/mountd/auth.c b/utils/mountd/auth.c index d88c46f..eb9cdeb 100644 --- a/utils/mountd/auth.c +++ b/utils/mountd/auth.c @@ -25,15 +25,10 @@ enum auth_error no_entry, not_exported, illegal_port, - faked_hostent, - no_forward_dns, success }; static void auth_fixpath(char *path); -static nfs_export* auth_authenticate_internal - (char *what, struct sockaddr_in *caller, char *path, - struct hostent **hpp, enum auth_error *error); static char *export_file = NULL; void @@ -66,56 +61,12 @@ auth_reload() static nfs_export * auth_authenticate_internal(char *what, struct sockaddr_in *caller, - char *path, struct hostent **hpp, + char *path, struct hostent *hp, enum auth_error *error) { - struct in_addr addr = caller->sin_addr; nfs_export *exp; - if (path[0] != '/') { - *error = bad_path; - return NULL; - } - auth_fixpath(path); - - if (!(*hpp = gethostbyaddr((const char *)&addr, sizeof(addr), AF_INET))) - *hpp = get_hostent((const char *)&addr, sizeof(addr), - AF_INET); - else { - /* must make sure the hostent is authorative. */ - char **sp; - struct hostent *forward = NULL; - char *tmpname; - - *hpp = hostent_dup (*hpp); - tmpname = xstrdup((*hpp)->h_name); - if (tmpname) { - forward = gethostbyname(tmpname); - free(tmpname); - } - if (forward) { - /* now make sure the "addr" is in the list */ - for (sp = forward->h_addr_list ; *sp ; sp++) { - if (memcmp(*sp, &addr, forward->h_length)==0) - break; - } - - if (!*sp) { - /* it was a FAKE */ - *error = faked_hostent; - return NULL; - } - free (*hpp); - *hpp = hostent_dup (forward); - } - else { - /* never heard of it. misconfigured DNS? */ - *error = no_forward_dns; - return NULL; - } - } - - if (!(exp = export_find(*hpp, path))) { + if (!(exp = export_find(hp, path))) { *error = no_entry; return NULL; } @@ -154,15 +105,20 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path) strncpy(epath, path, sizeof (epath) - 1); epath[sizeof (epath) - 1] = '\0'; + auth_fixpath(epath); /* strip duplicate '/' etc */ + + hp = get_reliable_hostbyaddr((const char*)&caller->sin_addr, sizeof(struct in_addr), + AF_INET); + if (!hp) + hp = get_hostent((const char*)&caller->sin_addr, sizeof(struct in_addr), + AF_INET); + if (!hp) + return exp; /* Try the longest matching exported pathname. */ while (1) { - if (hp) { - free (hp); - hp = NULL; - } exp = auth_authenticate_internal(what, caller, epath, - &hp, &error); + hp, &error); if (exp || (error != not_exported && error != no_entry)) break; /* We have to treat the root, "/", specially. */ @@ -171,6 +127,7 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path) if (p == epath) p++; *p = '\0'; } + free(hp); switch (error) { case bad_path: @@ -198,16 +155,6 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path) what, hp->h_name, path, epath, ntohs(caller->sin_port)); break; - case faked_hostent: - xlog(L_WARNING, "refused %s request from %s (%s) for %s (%s): DNS forward lookup does't match with reverse", - what, inet_ntoa(addr), hp->h_name, path, epath); - break; - - case no_forward_dns: - xlog(L_WARNING, "refused %s request from %s (%s) for %s (%s): no DNS forward lookup", - what, inet_ntoa(addr), hp->h_name, path, epath); - break; - case success: xlog(L_NOTICE, "authenticated %s request from %s:%d for %s (%s)", what, hp->h_name, ntohs(caller->sin_port), path, epath); |