summaryrefslogtreecommitdiffstats
path: root/utils/nfsstat/nfsstat.c
diff options
context:
space:
mode:
authorSean Finney <sean.finney@sonyericsson.com>2011-04-19 11:04:35 -0400
committerSteve Dickson <steved@redhat.com>2011-04-19 12:30:34 -0400
commit5604b35a61e22930873ffc4e9971002f578e7978 (patch)
tree814c7c116b757e194e1d62a185eaf8faccf9ec74 /utils/nfsstat/nfsstat.c
parent9274e94db85bac04e170414cb8e0f4be271cde90 (diff)
downloadnfs-utils-5604b35a61e22930873ffc4e9971002f578e7978.tar.gz
nfs-utils-5604b35a61e22930873ffc4e9971002f578e7978.tar.xz
nfs-utils-5604b35a61e22930873ffc4e9971002f578e7978.zip
nfs-utils: Increase the stdio file buffer size for procfs files
Previously, when writing to /proc/net/rpc/*/channel, if a cache line were larger than the default buffer size (likely 1024 bytes), mountd and svcgssd would split writes into a number of buffer-sized writes. Each of these writes would get an EINVAL error back from the kernel procfs handle (it expects line-oriented input and does not account for multiple/split writes), and no cache update would occur. When such behavior occurs, NFS clients depending on mountd to finish the cache operation would block/hang, or receive EPERM, depending on the context of the operation. This is likely to happen if a user is a member of a large (~100-200) number of groups. Instead, every fopen() on the procfs files in question is followed by a call to setvbuf(), using a per-file dedicated buffer of RPC_CHAN_BUF_SIZE length. Really, mountd should not be using stdio-style buffered file operations on files in /proc to begin with. A better solution would be to use internally managed buffers and calls to write() instead of these stdio calls, but that would be a more extensive change; so this is proposed as a quick and not-so-dirty fix in the meantime. Signed-off-by: Sean Finney <sean.finney@sonyericsson.com> Signed-off-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'utils/nfsstat/nfsstat.c')
0 files changed, 0 insertions, 0 deletions