diff options
| author | Steve Dickson <steved@redhat.com> | 2015-07-30 17:06:39 -0400 |
|---|---|---|
| committer | Steve Dickson <steved@redhat.com> | 2015-07-31 08:16:22 -0400 |
| commit | a705076172b274463563416adffe55f129740267 (patch) | |
| tree | f84a32495d3de0a95bb1e813ed35d4c0221ac0ca /utils/gssd/krb5_util.c | |
| parent | 9bfca466c97ffff94f15923905d39782d0c85249 (diff) | |
| download | nfs-utils-a705076172b274463563416adffe55f129740267.tar.gz nfs-utils-a705076172b274463563416adffe55f129740267.tar.xz nfs-utils-a705076172b274463563416adffe55f129740267.zip | |
rpc.gssd: Only clear the retval if it has not been set
In gssd_search_krb5_keytab() an error code can be
cleared by blindly setting retval to zero.
Reported-by: Jianhong Yin <jiyin@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'utils/gssd/krb5_util.c')
| -rw-r--r-- | utils/gssd/krb5_util.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index f1ebc0d..ecf17a2 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -772,7 +772,9 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, "keytab '%s'\n", k5err, kt_name); } - retval = 0; + /* Only clear the retval if has not been set */ + if (retval < 0) + retval = 0; out: free(k5err); return retval; |