summaryrefslogtreecommitdiffstats
path: root/support/export/client.c
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2010-05-05 14:42:01 -0400
committerSteve Dickson <steved@redhat.com>2010-05-05 15:42:29 -0400
commit6ff1fd42db18c657fbc5f81169a566b41d53e731 (patch)
tree46cfe63c5a09f6282fde8fd0bde9341c68cdcea2 /support/export/client.c
parent9bb85c5e8d2285f82367c75df5530a71a9a5a5f2 (diff)
downloadnfs-utils-6ff1fd42db18c657fbc5f81169a566b41d53e731.tar.gz
nfs-utils-6ff1fd42db18c657fbc5f81169a566b41d53e731.tar.xz
nfs-utils-6ff1fd42db18c657fbc5f81169a566b41d53e731.zip
libexport.a: Clean up client_add()
Clean up: client_add()'s current callers never set unknown m_type values, so the m_type check is unnecessary. All of client_add()'s callers are in the same source file where it is defined, so make it a static helper function. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'support/export/client.c')
-rw-r--r--support/export/client.c26
1 files changed, 12 insertions, 14 deletions
diff --git a/support/export/client.c b/support/export/client.c
index 9259180..4600255 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -113,6 +113,18 @@ client_init(nfs_client *clp, const char *hname, const struct hostent *hp)
return 1;
}
+static void
+client_add(nfs_client *clp)
+{
+ nfs_client **cpp;
+
+ cpp = &clientlist[clp->m_type];
+ while (*cpp != NULL)
+ cpp = &((*cpp)->m_next);
+ clp->m_next = NULL;
+ *cpp = clp;
+}
+
/* if canonical is set, then we *know* this is already a canonical name
* so hostname lookup is avoided.
* This is used when reading /proc/fs/nfs/exports
@@ -209,20 +221,6 @@ client_dup(nfs_client *clp, struct hostent *hp)
}
void
-client_add(nfs_client *clp)
-{
- nfs_client **cpp;
-
- if (clp->m_type < 0 || clp->m_type >= MCL_MAXTYPES)
- xlog(L_FATAL, "unknown client type in client_add");
- cpp = clientlist + clp->m_type;
- while (*cpp)
- cpp = &((*cpp)->m_next);
- clp->m_next = NULL;
- *cpp = clp;
-}
-
-void
client_release(nfs_client *clp)
{
if (clp->m_count <= 0)