summaryrefslogtreecommitdiffstats
path: root/support/export/client.c
diff options
context:
space:
mode:
authorSteinar H. Gunderson <sesse@debian.org>2007-05-11 21:02:09 +1000
committerNeil Brown <neilb@suse.de>2007-05-11 21:02:09 +1000
commit1cb4a250fb9f0a8ba34befa47d951430e444a58e (patch)
tree1c6bf7e2cb9e32d425bcf696390c21c47173d36c /support/export/client.c
parentcfb9b2e41177340926a0d5a45a149ccff7b324bc (diff)
downloadnfs-utils-1cb4a250fb9f0a8ba34befa47d951430e444a58e.tar.gz
nfs-utils-1cb4a250fb9f0a8ba34befa47d951430e444a58e.tar.xz
nfs-utils-1cb4a250fb9f0a8ba34befa47d951430e444a58e.zip
Memory leak in mountd
In client_compose(), free() the hostent structure returned before exiting. Normally, gethostbyaddr() returns a pointer to a static struct, but this hostent comes from either get_reliable_hostbyaddr() or get_hostent(), both which return a pointer they privately xmalloc()ed, which thus can and should be free()d. Signed-Off-By: Steinar H. Gunderson <sesse@debian.org>
Diffstat (limited to 'support/export/client.c')
-rw-r--r--support/export/client.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/support/export/client.c b/support/export/client.c
index 686c744..19b53aa 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -262,6 +262,7 @@ client_compose(struct in_addr addr)
name = add_name(name, clp->m_hostname);
}
}
+ free(he);
return name;
}