summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2012-08-06 08:55:45 -0400
committerSteve Dickson <steved@redhat.com>2012-08-06 09:11:27 -0400
commitd9f51f267e459c975833ac853ce41809ca492ab0 (patch)
tree53e9dc56efc4ba60594bbe4bd8f0b319f3339b49
parent6019ff50055ee189557b55aad781bb12beb95e19 (diff)
downloadnfs-utils-d9f51f267e459c975833ac853ce41809ca492ab0.zip
nfs-utils-d9f51f267e459c975833ac853ce41809ca492ab0.tar.gz
nfs-utils-d9f51f267e459c975833ac853ce41809ca492ab0.tar.xz
rpc.gssd: don't call printerr from signal handler
From: "J. Bruce Fields" <bfields@redhat.com> printerr() isn't actually safe to call from a signal handler. It might be possible to make it so, but I think this is the only case in nfs-utils where we try to, and I'm not convince it's worth it. This fixes a bug that would eventually cause mounts to hang when gssd is run with -vv. Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Steve Dickson <steved@redhat.com>
-rw-r--r--utils/gssd/gssd_main_loop.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/utils/gssd/gssd_main_loop.c b/utils/gssd/gssd_main_loop.c
index 9954ffb..6914687 100644
--- a/utils/gssd/gssd_main_loop.c
+++ b/utils/gssd/gssd_main_loop.c
@@ -61,10 +61,8 @@ extern int pollsize;
static volatile int dir_changed = 1;
-static void dir_notify_handler(int sig)
+static void dir_notify_handler(__attribute__((unused))int sig)
{
- printerr(2, "dir_notify_handler: sig %d\n", sig);
-
dir_changed = 1;
}