Homogeneized error handling for HTTP methods in requests.

Reworked error codes, so that positive and negative numbers don't overlap:
It will be easier to change the sign of an error code without break API.

Realigned error codes definitions.

1 files changed, 35 insertions, 32 deletions

diff --git a/swig/Lasso.i b/swig/Lasso.i
index 68679fc6..9ff1e39d 100644
--- a/swig/Lasso.i
+++ b/swig/Lasso.i
@@ -418,16 +418,15 @@ typedef enum {
 %rename(XML_ERROR_ATTR_NOT_FOUND) LASSO_XML_ERROR_ATTR_NOT_FOUND;
 %rename(XML_ERROR_ATTR_VALUE_NOT_FOUND) LASSO_XML_ERROR_ATTR_VALUE_NOT_FOUND;
 #endif
-#define LASSO_XML_ERROR_NODE_NOT_FOUND -10
-#define LASSO_XML_ERROR_NODE_CONTENT_NOT_FOUND -11
-#define LASSO_XML_ERROR_ATTR_NOT_FOUND -12
-#define LASSO_XML_ERROR_ATTR_VALUE_NOT_FOUND -13
+#define LASSO_XML_ERROR_NODE_NOT_FOUND                 -10
+#define LASSO_XML_ERROR_NODE_CONTENT_NOT_FOUND         -11
+#define LASSO_XML_ERROR_ATTR_NOT_FOUND                 -12
+#define LASSO_XML_ERROR_ATTR_VALUE_NOT_FOUND           -13
 
 /* XMLDSig */
 #ifndef SWIGPHP4
 %rename(DS_ERROR_SIGNATURE_NOT_FOUND) LASSO_DS_ERROR_SIGNATURE_NOT_FOUND;
 %rename(DS_ERROR_INVALID_SIGNATURE) LASSO_DS_ERROR_INVALID_SIGNATURE;
-
 %rename(DS_ERROR_SIGNATURE_TMPL_CREATION_FAILED) LASSO_DS_ERROR_SIGNATURE_TMPL_CREATION_FAILED;
 %rename(DS_ERROR_CONTEXT_CREATION_FAILED) LASSO_DS_ERROR_CONTEXT_CREATION_FAILED;
 %rename(DS_ERROR_PUBLIC_KEY_LOAD_FAILED) LASSO_DS_ERROR_PUBLIC_KEY_LOAD_FAILED;
@@ -440,42 +439,47 @@ typedef enum {
 %rename(DS_ERROR_CA_CERT_CHAIN_LOAD_FAILED) LASSO_DS_ERROR_CA_CERT_CHAIN_LOAD_FAILED;
 %rename(LASSO_DS_ERROR_INVALID_SIGALG) LASSO_DS_ERROR_INVALID_SIGALG;
 #endif
-#define LASSO_DS_ERROR_SIGNATURE_NOT_FOUND 101
-#define LASSO_DS_ERROR_INVALID_SIGNATURE 102
-
-#define LASSO_DS_ERROR_SIGNATURE_TMPL_CREATION_FAILED -101
-#define LASSO_DS_ERROR_CONTEXT_CREATION_FAILED -102
-#define LASSO_DS_ERROR_PUBLIC_KEY_LOAD_FAILED -103
-#define LASSO_DS_ERROR_PRIVATE_KEY_LOAD_FAILED -104
-#define LASSO_DS_ERROR_CERTIFICATE_LOAD_FAILED -105
-#define LASSO_DS_ERROR_SIGNATURE_FAILED -106
-#define LASSO_DS_ERROR_KEYS_MNGR_CREATION_FAILED -107
-#define LASSO_DS_ERROR_KEYS_MNGR_INIT_FAILED -108
-#define LASSO_DS_ERROR_SIGNATURE_VERIFICATION_FAILED -109
-#define LASSO_DS_ERROR_CA_CERT_CHAIN_LOAD_FAILED -110
-#define LASSO_DS_ERROR_INVALID_SIGALG -111
+#define LASSO_DS_ERROR_SIGNATURE_NOT_FOUND             101
+#define LASSO_DS_ERROR_INVALID_SIGNATURE               102
+#define LASSO_DS_ERROR_SIGNATURE_TMPL_CREATION_FAILED -103
+#define LASSO_DS_ERROR_CONTEXT_CREATION_FAILED        -104
+#define LASSO_DS_ERROR_PUBLIC_KEY_LOAD_FAILED         -105
+#define LASSO_DS_ERROR_PRIVATE_KEY_LOAD_FAILED        -106
+#define LASSO_DS_ERROR_CERTIFICATE_LOAD_FAILED        -107
+#define LASSO_DS_ERROR_SIGNATURE_FAILED               -108
+#define LASSO_DS_ERROR_KEYS_MNGR_CREATION_FAILED      -109
+#define LASSO_DS_ERROR_KEYS_MNGR_INIT_FAILED          -110
+#define LASSO_DS_ERROR_SIGNATURE_VERIFICATION_FAILED  -111
+#define LASSO_DS_ERROR_CA_CERT_CHAIN_LOAD_FAILED      -112
+#define LASSO_DS_ERROR_INVALID_SIGALG                 -113
 
 /* server */
 #ifndef SWIGPHP4
 %rename(SERVER_ERROR_PROVIDER_NOT_FOUND) LASSO_SERVER_ERROR_PROVIDER_NOT_FOUND;
 %rename(SERVER_ERROR_ADD_PROVIDER_FAILED) LASSO_SERVER_ERROR_ADD_PROVIDER_FAILED;
 #endif
-#define LASSO_SERVER_ERROR_PROVIDER_NOT_FOUND -201
-#define LASSO_SERVER_ERROR_ADD_PROVIDER_FAILED -202
+#define LASSO_SERVER_ERROR_PROVIDER_NOT_FOUND         -201
+#define LASSO_SERVER_ERROR_ADD_PROVIDER_FAILED        -202
 
 /* logout */
 #ifndef SWIGPHP4
 %rename(LOGOUT_ERROR_UNSUPPORTED_PROFILE) LASSO_LOGOUT_ERROR_UNSUPPORTED_PROFILE;
 #endif
-#define LASSO_LOGOUT_ERROR_UNSUPPORTED_PROFILE -301
+#define LASSO_LOGOUT_ERROR_UNSUPPORTED_PROFILE        -301
 
 /* profile */
 #ifndef SWIGPHP4
 %rename(PROFILE_ERROR_INVALID_QUERY) LASSO_PROFILE_ERROR_INVALID_QUERY;
+%rename(PROFILE_ERROR_INVALID_POST_MSG) LASSO_PROFILE_ERROR_INVALID_POST_MSG;
+%rename(PROFILE_ERROR_INVALID_SOAP_MSG) LASSO_PROFILE_ERROR_INVALID_SOAP_MSG;
 %rename(PROFILE_ERROR_MISSING_REQUEST) LASSO_PROFILE_ERROR_MISSING_REQUEST;
+%rename(PROFILE_ERROR_INVALID_HTTP_METHOD) LASSO_PROFILE_ERROR_INVALID_HTTP_METHOD;
 #endif
-#define LASSO_PROFILE_ERROR_INVALID_QUERY -401
-#define LASSO_PROFILE_ERROR_MISSING_REQUEST -402
+#define LASSO_PROFILE_ERROR_INVALID_QUERY              401
+#define LASSO_PROFILE_ERROR_INVALID_POST_MSG          -402
+#define LASSO_PROFILE_ERROR_INVALID_SOAP_MSG          -403
+#define LASSO_PROFILE_ERROR_MISSING_REQUEST           -404
+#define LASSO_PROFILE_ERROR_INVALID_HTTP_METHOD       -404
 
 /* functions/methods parameters checking */
 #ifndef SWIGPHP4
@@ -483,9 +487,9 @@ typedef enum {
 %rename(PARAM_ERROR_INVALID_VALUE) LASSO_PARAM_ERROR_INVALID_VALUE;
 %rename(PARAM_ERROR_ERR_CHECK_FAILED) LASSO_PARAM_ERROR_ERR_CHECK_FAILED;
 #endif
-#define LASSO_PARAM_ERROR_BADTYPE_OR_NULL_OBJ -501
-#define LASSO_PARAM_ERROR_INVALID_VALUE -502
-#define LASSO_PARAM_ERROR_ERR_CHECK_FAILED -503
+#define LASSO_PARAM_ERROR_BAD_TYPE_OR_NULL_OBJ        -501
+#define LASSO_PARAM_ERROR_INVALID_VALUE               -502
+#define LASSO_PARAM_ERROR_CHECK_FAILED                -503
 
 /* login */
 #ifndef SWIGPHP4
@@ -493,16 +497,15 @@ typedef enum {
 %rename(LOGIN_ERROR_CONSENT_NOT_OBTAINED) LASSO_LOGIN_ERROR_CONSENT_NOT_OBTAINED;
 %rename(LASSO_LOGIN_ERROR_INVALID_NAMEIDPOLICY) LASSO_LOGIN_ERROR_INVALID_NAMEIDPOLICY;
 #endif
-#define LASSO_LOGIN_ERROR_FEDERATION_NOT_FOUND 601
-#define LASSO_LOGIN_ERROR_CONSENT_NOT_OBTAINED 602
-
-#define LASSO_LOGIN_ERROR_INVALID_NAMEIDPOLICY -601
+#define LASSO_LOGIN_ERROR_FEDERATION_NOT_FOUND         601
+#define LASSO_LOGIN_ERROR_CONSENT_NOT_OBTAINED         602
+#define LASSO_LOGIN_ERROR_INVALID_NAMEIDPOLICY        -603
 
 /* others */
 #ifndef SWIGPHP4
 %rename(ERROR_UNDEFINED) LASSO_ERROR_UNDEFINED;
 #endif
-#define LASSO_ERROR_UNDEFINED -999
+#define LASSO_ERROR_UNDEFINED                         -999
 
 
 /***********************************************************************