Reserved space for private_data expansion, so it will be possible to maintain

ABI compatibility if changes are needed.  Documented some functions (and
switched some destroy to use lasso_node_destroy).

7 files changed, 41 insertions, 4 deletions

diff --git a/lasso/id-ff/defederation.h b/lasso/id-ff/defederation.h
index ab3cbf63..12e58b4d 100644
--- a/lasso/id-ff/defederation.h
+++ b/lasso/id-ff/defederation.h
@@ -53,6 +53,8 @@ struct _LassoDefederation {
 
 struct _LassoDefederationClass {
 	LassoProfileClass parent;
+	/*< private >*/
+	void *private_data;  /* reserved for future use */
 };
 
 LASSO_EXPORT GType lasso_defederation_get_type(void);
diff --git a/lasso/id-ff/lecp.h b/lasso/id-ff/lecp.h
index 9cb480d1..8009ed48 100644
--- a/lasso/id-ff/lecp.h
+++ b/lasso/id-ff/lecp.h
@@ -50,10 +50,13 @@ typedef struct _LassoLecpClass LassoLecpClass;
 struct _LassoLecp {
 	LassoLogin parent;
 
+	/*< public >*/
 	LassoLibAuthnRequestEnvelope *authnRequestEnvelope;
 	LassoLibAuthnResponseEnvelope *authnResponseEnvelope;
-
 	char *assertionConsumerServiceURL;
+
+	/*< private >*/
+	void *private_data;  /* reserved for future use */
 };
 
 struct _LassoLecpClass {
diff --git a/lasso/id-ff/login.c b/lasso/id-ff/login.c
index b403f389..c1408abb 100644
--- a/lasso/id-ff/login.c
+++ b/lasso/id-ff/login.c
@@ -790,7 +790,7 @@ lasso_login_build_response_msg(LassoLogin *login, gchar *remote_providerID)
  * lasso_login_destroy:
  * @login: a #LassoLogin
  * 
- * Destroys a login object.
+ * Destroys a #LassoLogin object.
  **/
 void
 lasso_login_destroy(LassoLogin *login)
diff --git a/lasso/id-ff/name_identifier_mapping.c b/lasso/id-ff/name_identifier_mapping.c
index 1fb3eb0f..f1c16052 100644
--- a/lasso/id-ff/name_identifier_mapping.c
+++ b/lasso/id-ff/name_identifier_mapping.c
@@ -105,10 +105,17 @@ lasso_name_identifier_mapping_build_response_msg(LassoNameIdentifierMapping *map
 	return 0;
 }
 
+
+/**
+ * lasso_name_identifier_mapping_destroy:
+ * @mapping: a #LassoNameIdentifierMapping
+ * 
+ * Destroys a #LassoNameIdentifierMapping object.
+ **/
 void
 lasso_name_identifier_mapping_destroy(LassoNameIdentifierMapping *mapping)
 {
-	g_object_unref(G_OBJECT(mapping));
+	lasso_node_destroy(LASSO_NODE(mapping));
 }
 
 gint
@@ -438,6 +445,15 @@ lasso_name_identifier_mapping_get_type()
 	return this_type;
 }
 
+/**
+ * lasso_name_identifier_mapping_new
+ * @server: the #LassoServer
+ *
+ * Creates a new #LassoNameIdentifierMapping.
+ *
+ * Return value: a newly created #LassoNameIdentifierMapping object; or NULL
+ *     if an error occured
+ **/
 LassoNameIdentifierMapping *
 lasso_name_identifier_mapping_new(LassoServer *server)
 {
diff --git a/lasso/id-ff/name_identifier_mapping.h b/lasso/id-ff/name_identifier_mapping.h
index a1c23dc4..eb8a64d8 100644
--- a/lasso/id-ff/name_identifier_mapping.h
+++ b/lasso/id-ff/name_identifier_mapping.h
@@ -55,7 +55,12 @@ typedef struct _LassoNameIdentifierMappingClass LassoNameIdentifierMappingClass;
 
 struct _LassoNameIdentifierMapping {
 	LassoProfile parent;
+
+	/*< public >*/
 	gchar *targetNameIdentifier;
+
+	/*< private >*/
+	void *private_data;  /* reserved for future use */
 };
 
 struct _LassoNameIdentifierMappingClass {
diff --git a/lasso/id-ff/name_registration.c b/lasso/id-ff/name_registration.c
index db0a53dd..e6058d2f 100644
--- a/lasso/id-ff/name_registration.c
+++ b/lasso/id-ff/name_registration.c
@@ -155,10 +155,16 @@ lasso_name_registration_build_response_msg(LassoNameRegistration *name_registrat
 	return critical_error(LASSO_PROFILE_ERROR_INVALID_HTTP_METHOD);
 }
 
+/**
+ * lasso_name_registration_destroy:
+ * @name_registration: a #LassoNameRegistration
+ * 
+ * Destroys a #LassoNameRegistration object.
+ **/
 void
 lasso_name_registration_destroy(LassoNameRegistration *name_registration)
 {
-	g_object_unref(G_OBJECT(name_registration));
+	lasso_node_destroy(LASSO_NODE(name_registration));
 }
 
 gint
diff --git a/lasso/id-ff/name_registration.h b/lasso/id-ff/name_registration.h
index aa045d7c..096031bd 100644
--- a/lasso/id-ff/name_registration.h
+++ b/lasso/id-ff/name_registration.h
@@ -53,7 +53,12 @@ typedef struct _LassoNameRegistrationClass LassoNameRegistrationClass;
 
 struct _LassoNameRegistration {
 	LassoProfile parent;
+
+	/*< public >*/
 	LassoSamlNameIdentifier *oldNameIdentifier;
+	
+	/*< private >*/
+	void *private_data;  /* reserved for future use */
 };
 
 struct _LassoNameRegistrationClass {