diff options
| author | Frederic Peters <fpeters@entrouvert.com> | 2006-12-27 15:24:56 +0000 |
|---|---|---|
| committer | Frederic Peters <fpeters@entrouvert.com> | 2006-12-27 15:24:56 +0000 |
| commit | 0970475f12c75d886800cdbc4fd11f22ec617364 (patch) | |
| tree | daf3b29e5cc61106e96da5017eec9b4faecdb835 /lasso | |
| parent | dc6243cd5d024dd9d552e81d4f793a33a69abc43 (diff) | |
| download | lasso-0970475f12c75d886800cdbc4fd11f22ec617364.tar.gz lasso-0970475f12c75d886800cdbc4fd11f22ec617364.tar.xz lasso-0970475f12c75d886800cdbc4fd11f22ec617364.zip | |
fixing some usage of unitialized variables in SAMLv2 support
Diffstat (limited to 'lasso')
| -rw-r--r-- | lasso/saml-2.0/ecp.c | 4 | ||||
| -rw-r--r-- | lasso/saml-2.0/login.c | 3 | ||||
| -rw-r--r-- | lasso/saml-2.0/provider.c | 5 |
3 files changed, 5 insertions, 7 deletions
diff --git a/lasso/saml-2.0/ecp.c b/lasso/saml-2.0/ecp.c index 5ab78cf6..8f6e9dfc 100644 --- a/lasso/saml-2.0/ecp.c +++ b/lasso/saml-2.0/ecp.c @@ -188,7 +188,7 @@ lasso_ecp_process_response_msg(LassoEcp *ecp, const char *response_msg) xmlDoc *doc; xmlXPathContext *xpathCtx; xmlXPathObject *xpathObj; - xmlNode *envelope, *new_envelope, *header, *paos_response, *ecp_relay_state; + xmlNode *new_envelope, *header, *paos_response, *ecp_relay_state; xmlNode *body = NULL; xmlOutputBuffer *buf; xmlCharEncodingHandler *handler; @@ -220,7 +220,7 @@ lasso_ecp_process_response_msg(LassoEcp *ecp, const char *response_msg) header = xmlNewTextChild(new_envelope, NULL, (xmlChar*)"Header", NULL); /* PAOS request header block */ - soap_env_ns = xmlNewNs(envelope, + soap_env_ns = xmlNewNs(new_envelope, (xmlChar*)LASSO_SOAP_ENV_HREF, (xmlChar*)LASSO_SOAP_ENV_PREFIX); paos_response = xmlNewNode(NULL, (xmlChar*)"Response"); xmlSetNs(paos_response, xmlNewNs(paos_response, diff --git a/lasso/saml-2.0/login.c b/lasso/saml-2.0/login.c index 9c95a981..1ee98464 100644 --- a/lasso/saml-2.0/login.c +++ b/lasso/saml-2.0/login.c @@ -1039,9 +1039,10 @@ lasso_saml20_login_process_response_status_and_assertion(LassoLogin *login) return LASSO_LOGIN_ERROR_STATUS_NOT_SUCCESS; } + profile = LASSO_PROFILE(login); + if (LASSO_SAMLP2_RESPONSE(response)->Assertion != NULL || LASSO_SAMLP2_RESPONSE(response)->EncryptedAssertion != NULL) { - profile = LASSO_PROFILE(login); encryption_private_key = profile->server->private_data->encryption_private_key; if (profile->remote_providerID == NULL) return LASSO_PROFILE_ERROR_MISSING_REMOTE_PROVIDERID; diff --git a/lasso/saml-2.0/provider.c b/lasso/saml-2.0/provider.c index 782a494c..988acd54 100644 --- a/lasso/saml-2.0/provider.c +++ b/lasso/saml-2.0/provider.c @@ -283,10 +283,7 @@ lasso_saml20_provider_get_assertion_consumer_service_url_by_binding(LassoProvide GHashTable *descriptor; GList *l = NULL, *r = NULL; char *name; - char *binding_s; -/* const char *possible_bindings[] = { */ -/* "HTTP-Artifact", "HTTP-Post", "HTTP-POST", "SOAP", NULL */ -/* }; */ + char *binding_s = NULL; int lname; descriptor = provider->private_data->SPDescriptor; |