Rework cleanup handling

 * lasso/utils.h:
   change 'goto exit' for 'goto cleanup'. rename all goto_exit macros to
   goto_cleanup_.  rename goto_cleanup_if_fail to
   goto_cleanup_if_fail_with_rc and add a
   goto_cleanup_if_fail for function which do not return an integer
   value. add documentation for goto_cleanup macro family.
 * lasso/id-ff/login.c:
 * lasso/id-ff/provider.c:
 * lasso/id-ff/server.c:
 * lasso/id-ff/session.c:
 * lasso/id-wsf/discovery.c:
 * lasso/id-wsf/wsf_profile.c:
 * lasso/saml-2.0/profile.c:
 * lasso/utils.h:
 * lasso/xml/lib_logout_request.c:
 * lasso/xml/tools.c:
 * lasso/xml/xml.c:
   update name of goto_exit_if_fail macros. rename 'exit' labels to
   'cleanup'.

1 files changed, 2 insertions, 2 deletions

diff --git a/lasso/xml/lib_logout_request.c b/lasso/xml/lib_logout_request.c
index f5f6442a..caf41b43 100644
--- a/lasso/xml/lib_logout_request.c
+++ b/lasso/xml/lib_logout_request.c
@@ -100,7 +100,7 @@ init_from_query(LassoNode *node, char **query_fields)
 
 	rc = parent_class->init_from_query(node, query_fields);
 	if (! rc)
-		goto exit;
+		goto cleanup;
 
 	if (request->ProviderID == NULL ||
 			request->NameIdentifier == NULL ||
@@ -113,7 +113,7 @@ init_from_query(LassoNode *node, char **query_fields)
 		lasso_assign_string(request->NameIdentifier->Format,
 				"LASSO_SAML2_NAME_IDENTIFIER_FORMAT_UNSPECIFIED");
 	}
- exit:
+cleanup:
 
 	return rc;
 }