Core: add missing return value owner semantic annotations to getters

 * lasso/id-ff/provider.c:
   fix lasso_provider_get_base64_succinct_id, it returned a libxml
   string, copy it with g_strdup before releasing it to stay with GLib
   allocated string in return values.

4 files changed, 22 insertions, 20 deletions

diff --git a/lasso/id-wsf/data_service.c b/lasso/id-wsf/data_service.c
index f62632e1..7377a978 100644
--- a/lasso/id-wsf/data_service.c
+++ b/lasso/id-wsf/data_service.c
@@ -211,7 +211,7 @@ lasso_data_service_add_query_item(LassoDataService *service,
  * @service: a #LassoDataService
  * @select: the select string of the query item to found
  * @item_id: the item id of the query item to found
- * @output: a #LassoDstQueryItem handle to store the result object, its reference count is not
+ * @output:(transfer none): a #LassoDstQueryItem handle to store the result object, its reference count is not
  * incremented.
  *
  * Look up the first query item in the current request matching the given criteria, @select or
@@ -300,7 +300,7 @@ lasso_data_service_build_response_msg(LassoDataService *service)
 /**
  * lasso_data_service_get_answers:
  * @service: a #LassoDataService object.
- * @output: (element-type xmlNode): an xmlNode** pointer where to put the xmlNode* of the result
+ * @output:(transfer full)(allow-none)(element-type xmlNode): an xmlNode** pointer where to put the xmlNode* of the result
  *
  * Get all the xmlNode content of the first Data element of the QueryResponse message.
  *
@@ -1240,7 +1240,7 @@ lasso_data_service_new_full(LassoServer *server, LassoDiscoResourceOffering *off
  * @service: a #LassoDataService object
  * @resource_data: (allow-none): an xmlnode representing the resource data of the service
  *
- *  FIXME: add documentation
+ * Set the resource data content.
  */
 void
 lasso_data_service_set_resource_data(LassoDataService *service, const xmlNode *resource_data)
@@ -1250,10 +1250,12 @@ lasso_data_service_set_resource_data(LassoDataService *service, const xmlNode *r
 
 
 /**
- * lasso_data_service_set_resource_data:
+ * lasso_data_service_get_resource_data:
  * @service: a #LassoDataService object
  *
- * FIXME: add documentation.
+ * Return the XML resrouce data in this data service.
+ *
+ * Return value:(transfer full)(allow-none): a newly allocated #xmlNode or NULL.
  */
 xmlNode *
 lasso_data_service_get_resource_data(LassoDataService *service)
diff --git a/lasso/id-wsf/discovery.c b/lasso/id-wsf/discovery.c
index 10973962..5a7d39fb 100644
--- a/lasso/id-wsf/discovery.c
+++ b/lasso/id-wsf/discovery.c
@@ -661,7 +661,7 @@ cleanup:
  * requested @service_type with the first resource offering found or the first resource offering
  * matching the service type.
  *
- * Return value: a newly created #LassoDataService object; or NULL if an
+ * Return value:(transfer full)(allow-none): a newly created #LassoDataService object; or NULL if an
  *     error occured.
  **/
 LassoWsfProfile*
@@ -705,7 +705,7 @@ lasso_discovery_get_service(LassoDiscovery *discovery, const char *service_type)
  *
  * After a disco:query message, creates a GList object of #LassoDataService.
  *
- * Return value:(element-type LassoNode): a newly created GList object of #LassoDataService;
+ * Return value:(transfer full)(element-type LassoNode): a newly created GList object of #LassoDataService;
  *     or NULL if an error occured.
  **/
 GList*
diff --git a/lasso/id-wsf/id_ff_extensions.c b/lasso/id-wsf/id_ff_extensions.c
index 50782763..4d2acc29 100644
--- a/lasso/id-wsf/id_ff_extensions.c
+++ b/lasso/id-wsf/id_ff_extensions.c
@@ -295,7 +295,7 @@ void add_matching_resource_offering_to_list(G_GNUC_UNUSED char *name, LassoDisco
  *
  * Returns a list of #LassoDiscoResourceOffering associated to this service type.
  *
- * Return value:(element-type LassoDiscoResourceOffering): a newly allocated list of #LassoDiscoResourceOffering
+ * Return value:(transfer full)(element-type LassoDiscoResourceOffering): a newly allocated list of #LassoDiscoResourceOffering
  */
 GList*
 lasso_identity_get_offerings(LassoIdentity *identity, const char *service_type)
@@ -320,7 +320,7 @@ lasso_identity_get_offerings(LassoIdentity *identity, const char *service_type)
  * usually allocated by lasso_identity_add_resource_offering() inside
  * offering->entryID.
  *
- * Return value: a #LassoDiscoResourceOffering, your must ref it if you intend
+ * Return value:(transfer none)(allow-none): a #LassoDiscoResourceOffering, your must ref it if you intend
  * to keep it around.
  */
 LassoDiscoResourceOffering*
@@ -370,7 +370,7 @@ lasso_server_add_service_from_dump(LassoServer *server, const gchar *dump)
  *
  * Look up a disco service instance corresponding to this service type.
  *
- * Return value: the #LassoDiscoServiceInstance, NULL if it was not found.
+ * Return value:(transfer none)(allow-none): the #LassoDiscoServiceInstance, NULL if it was not found.
  *     The #LassoDiscoServiceInstance is owned by Lasso and should not be
  *     freed.
  **/
diff --git a/lasso/id-wsf/wsf_profile.c b/lasso/id-wsf/wsf_profile.c
index 4dd052a8..abaa26d9 100644
--- a/lasso/id-wsf/wsf_profile.c
+++ b/lasso/id-wsf/wsf_profile.c
@@ -500,7 +500,7 @@ lasso_wsf_profile_set_security_mech_id(LassoWsfProfile *profile,
  * lasso_wsf_profile_get_security_mech_id:
  * @profile: the #LassoWsfProfile object
  *
- * Return value: the current security mechanism id for this object.
+ * Return value:(transfer none): the current security mechanism id for this object.
  */
 const char *
 lasso_wsf_profile_get_security_mech_id(LassoWsfProfile *profile)
@@ -533,7 +533,7 @@ lasso_wsf_profile_set_description(LassoWsfProfile *profile, LassoDiscoDescriptio
  * locate the endpoint and the security mechanism to use for the next ID-WSF
  * request.
  *
- * Return value: a #LassoDiscoDescriptio or NULL if none is present.
+ * Return value:(transfer full): a #LassoDiscoDescriptio or NULL if none is present.
  */
 LassoDiscoDescription *
 lasso_wsf_profile_get_description(const LassoWsfProfile *profile)
@@ -547,7 +547,7 @@ lasso_wsf_profile_get_description(const LassoWsfProfile *profile)
  *
  * Returns the ResourceOffering setupt with this profile object.
  *
- * Return value: a #LassoDiscoResourceOffering if one was setup during
+ * Return value:(transfer full): a #LassoDiscoResourceOffering if one was setup during
  * construction, NULL otherwise.
  */
 LassoDiscoResourceOffering *
@@ -596,7 +596,7 @@ lasso_wsf_profile_build_soap_envelope(const char *refToMessageId, const char *pr
  *
  * Gets the identity bound to @profile.
  *
- * Return value: the identity or NULL if it none was found.  The #LassoIdentity
+ * Return value:(transfer none)(allow-none): the identity or NULL if it none was found.  The #LassoIdentity
  *      object is internally allocated and must not be freed by the caller.
  **/
 LassoIdentity*
@@ -614,8 +614,8 @@ lasso_wsf_profile_get_identity(const LassoWsfProfile *profile)
  *
  * Gets the session bound to @profile.
  *
- * Return value: the session or NULL if it none was found.  The #LassoSession
- *      object is internally allocated and must not be freed by the caller.
+ * Return value:(transfer none)(allow-none): the session or NULL if it none was found. The
+ * #LassoSession object is internally allocated and must not be freed by the caller.
  **/
 LassoSession*
 lasso_wsf_profile_get_session(const LassoWsfProfile *profile)
@@ -1456,7 +1456,7 @@ cleanup:
  *
  * Return the remote provider id parsed in the last processing of a SOAP request or a SOAP response.
  *
- * Return value: the provider id string or NULL.
+ * Return value:(transfer none)(allow-none): the provider id string or NULL.
  */
 const char*
 lasso_wsf_profile_get_remote_provider_id(LassoWsfProfile *wsf_profile)
@@ -1469,7 +1469,7 @@ lasso_wsf_profile_get_remote_provider_id(LassoWsfProfile *wsf_profile)
 /**
  * lasso_wsf_profile_get_remote_provider:
  * @wsf_profile: a #LassoWsfProfile object
- * @provider_ref: an output pointer to #LassoProvider object variable.
+ * @provider:(transfer full): an output pointer to #LassoProvider object variable.
  *
  * Return the remote provider parsed in the last processing of a SOAP request or a SOAP response.
  *
@@ -1506,7 +1506,7 @@ lasso_wsf_profile_get_remote_provider(LassoWsfProfile *wsf_profile, LassoProvide
  *
  * If a fault is going to be returned as next response, return it.
  *
- * Return value: a #LassoSoapFault, or NULL if none is currently present in the object.
+ * Return value:(transfer none)(allow-none): a #LassoSoapFault, or NULL if none is currently present in the object.
  */
 LassoSoapFault*
 lasso_wsf_profile_get_soap_fault(LassoWsfProfile *wsf_profile)
@@ -1565,7 +1565,7 @@ lasso_wsf_profile_set_status_code(LassoWsfProfile *wsf_profile, const char *stat
  *
  * Return the actual status code for this protocol object.
  *
- * Return value: a string owned by the profile object or NULL.
+ * Return value:(transfer none)(allow-none): a string owned by the profile object or NULL.
  */
 const char*
 lasso_wsf_profile_get_status_code(LassoWsfProfile *wsf_profile) {