Core: add const modifier to return value of lasso_provider_get_metadata_list

 - lasso/id-ff/provider.c lasso/id-ff/provider.h:
   change return type of lasso_provider_get_metadata_list from GList* to
   const GList*.
 - lasso/id-ff/logout.c lasso/saml-2.0/logout.c
   lasso/saml-2.0/provider.c:
   change consumers of the API

5 files changed, 10 insertions, 10 deletions

diff --git a/lasso/id-ff/logout.c b/lasso/id-ff/logout.c
index d6220d53..c4dca36c 100644
--- a/lasso/id-ff/logout.c
+++ b/lasso/id-ff/logout.c
@@ -1010,7 +1010,7 @@ static LassoNodeClass *parent_class = NULL;
 static void
 check_soap_support(G_GNUC_UNUSED gchar *key, LassoProvider *provider, LassoProfile *profile)
 {
-	GList *supported_profiles;
+	const GList *supported_profiles;
 	LassoSamlAssertion *assertion;
 	LassoNode *assertion_n;
 
diff --git a/lasso/id-ff/provider.c b/lasso/id-ff/provider.c
index 11ccf669..8b172ec3 100644
--- a/lasso/id-ff/provider.c
+++ b/lasso/id-ff/provider.c
@@ -147,7 +147,7 @@ lasso_provider_get_metadata_one(const LassoProvider *provider, const char *name)
  *      allocated and points to internally allocated strings.  It must
  *      not be freed, modified or stored.
  **/
-GList*
+const GList*
 lasso_provider_get_metadata_list(const LassoProvider *provider, const char *name)
 {
 	GHashTable *descriptor;
@@ -177,9 +177,9 @@ lasso_provider_get_first_http_method(LassoProvider *provider,
 		const LassoProvider *remote_provider, const LassoMdProtocolType protocol_type)
 {
 	char *protocol_profile_prefix;
-	GList *local_supported_profiles;
-	GList *remote_supported_profiles;
-	GList *t1 = NULL, *t2 = NULL;
+	const GList *local_supported_profiles;
+	const GList *remote_supported_profiles;
+	const GList *t1, *t2 = NULL;
 	gboolean found;
 
 	g_return_val_if_fail(LASSO_IS_PROVIDER(provider), LASSO_HTTP_METHOD_NONE);
@@ -303,13 +303,13 @@ gboolean
 lasso_provider_has_protocol_profile(const LassoProvider *provider,
 		LassoMdProtocolType protocol_type, const char *protocol_profile)
 {
-	GList *supported;
+	const GList *supported;
 
 	g_return_val_if_fail(LASSO_IS_PROVIDER(provider), FALSE); /* Be conservative */
 	supported = lasso_provider_get_metadata_list(
 			provider, protocol_md_nodename[protocol_type]);
 
-	if (g_list_find_custom(supported, protocol_profile, (GCompareFunc)strcmp) == NULL)
+	if (g_list_find_custom((GList*)supported, protocol_profile, (GCompareFunc)strcmp) == NULL)
 		return FALSE;
 	return TRUE;
 }
diff --git a/lasso/id-ff/provider.h b/lasso/id-ff/provider.h
index f02b38bf..8abc89cd 100644
--- a/lasso/id-ff/provider.h
+++ b/lasso/id-ff/provider.h
@@ -175,7 +175,7 @@ LASSO_EXPORT LassoProvider* lasso_provider_new_from_buffer(LassoProviderRole rol
 LASSO_EXPORT gchar* lasso_provider_get_assertion_consumer_service_url(const LassoProvider *provider,
 		const char *service_id);
 LASSO_EXPORT gchar* lasso_provider_get_metadata_one(const LassoProvider *provider, const char *name);
-LASSO_EXPORT GList* lasso_provider_get_metadata_list(const LassoProvider *provider, const char *name);
+LASSO_EXPORT const GList* lasso_provider_get_metadata_list(const LassoProvider *provider, const char *name);
 
 LASSO_EXPORT LassoProvider* lasso_provider_new_from_dump(const gchar *dump);
 
diff --git a/lasso/saml-2.0/logout.c b/lasso/saml-2.0/logout.c
index 1a791023..0f3f1c1d 100644
--- a/lasso/saml-2.0/logout.c
+++ b/lasso/saml-2.0/logout.c
@@ -405,7 +405,7 @@ lasso_saml20_logout_validate_request(LassoLogout *logout)
 static void
 check_soap_support(G_GNUC_UNUSED gchar *key, LassoProvider *provider, LassoProfile *profile)
 {
-	GList *supported_profiles;
+	const GList *supported_profiles;
 	LassoSaml2Assertion *assertion;
 	LassoNode *assertion_n;
 
diff --git a/lasso/saml-2.0/provider.c b/lasso/saml-2.0/provider.c
index 8abd6ae6..cb9d7b3d 100644
--- a/lasso/saml-2.0/provider.c
+++ b/lasso/saml-2.0/provider.c
@@ -233,7 +233,7 @@ lasso_saml20_provider_get_first_http_method(LassoProvider *provider,
 
 	for (i=0; possible_bindings[i] && method == LASSO_HTTP_METHOD_NONE; i++) {
 		char *s;
-		GList *l1, *l2;
+		const GList *l1, *l2;
 
 		s = g_strdup_printf("%s %s", profile_names[protocol_type], possible_bindings[i]);
 		l1 = lasso_provider_get_metadata_list(provider, s);