missing includes, unusued variables, usual saturday stuff.

9 files changed, 16 insertions, 25 deletions

diff --git a/lasso/Attic/protocols/logout_request.c b/lasso/Attic/protocols/logout_request.c
index d33a5f51..843e8966 100644
--- a/lasso/Attic/protocols/logout_request.c
+++ b/lasso/Attic/protocols/logout_request.c
@@ -76,16 +76,9 @@ lasso_logout_request_new(gchar               *providerID,
 			 lassoSignatureType   sign_type,
 			 lassoSignatureMethod sign_method)
 {
-  LassoNodeClass *class;
   LassoNode *request, *identifier;
   xmlChar *request_id, *time;
 
-  xmlDocPtr doc = NULL;
-  xmlNodePtr xmlNode = NULL;
-  xmlIDPtr id;
-  xmlAttrPtr id_attr;
-  xmlChar *id_value;
-
 
   request = LASSO_NODE(g_object_new(LASSO_TYPE_LOGOUT_REQUEST, NULL));
   
@@ -278,7 +271,7 @@ static LassoNode *
 lasso_logout_request_new_from_xml(gchar *buffer)
 {
   LassoNode *request;
-  LassoNode *logout_request_node, *lassoNode_request;
+  LassoNode *lassoNode_request;
   xmlNodePtr xmlNode_request;
   LassoNodeClass *class;
 
diff --git a/lasso/Attic/protocols/logout_response.c b/lasso/Attic/protocols/logout_response.c
index 9fe18255..d33e5486 100644
--- a/lasso/Attic/protocols/logout_response.c
+++ b/lasso/Attic/protocols/logout_response.c
@@ -316,7 +316,7 @@ static LassoNode *
 lasso_logout_response_new_from_xml(gchar *buffer)
 {
   LassoNode *response;
-  LassoNode *logout_response_node, *lassoNode_response;
+  LassoNode *lassoNode_response;
   xmlNodePtr xmlNode_response;
   LassoNodeClass *class;
 
diff --git a/lasso/id-ff/defederation.c b/lasso/id-ff/defederation.c
index 291be891..83a0f22f 100644
--- a/lasso/id-ff/defederation.c
+++ b/lasso/id-ff/defederation.c
@@ -443,9 +443,7 @@ lasso_defederation_validate_notification(LassoDefederation *defederation)
   LassoProfile    *profile;
   LassoProvider   *provider;
   LassoFederation *federation;
-  LassoNode       *assertion, *nameIdentifier;
-  GError          *err = NULL;
-  gint             signature_check;
+  LassoNode       *nameIdentifier;
   gint             ret = 0;
   gint            remote_provider_type;
 
diff --git a/lasso/id-ff/identity.c b/lasso/id-ff/identity.c
index e638ec3d..7c4c889f 100644
--- a/lasso/id-ff/identity.c
+++ b/lasso/id-ff/identity.c
@@ -76,7 +76,6 @@ lasso_identity_add_federation(LassoIdentity   *identity,
 			      gchar           *remote_providerID,
 			      LassoFederation *federation)
 {
-  LassoFederation *old_federation;
   gboolean found = FALSE;
   int i;
 
diff --git a/lasso/id-ff/login.c b/lasso/id-ff/login.c
index 2e1ef8e7..8e5d85b7 100644
--- a/lasso/id-ff/login.c
+++ b/lasso/id-ff/login.c
@@ -218,7 +218,6 @@ lasso_login_process_response_status_and_assertion(LassoLogin *login) {
   LassoNode *assertion = NULL, *status = NULL, *statusCode = NULL;
   LassoProvider *idp = NULL;
   gchar *statusCode_value = NULL;
-  gint signature_check;
   gint ret = 0;
   GError *err = NULL;
 
@@ -849,7 +848,6 @@ lasso_login_get_assertion(LassoLogin *login)
 {
   LassoNodeClass *class;
   LassoAssertion *assertion;
-  LassoNode      *node;
   xmlNodePtr      assertion_xmlNode;
 
   g_return_val_if_fail(LASSO_IS_LOGIN(login), NULL);
diff --git a/lasso/id-ff/logout.c b/lasso/id-ff/logout.c
index ef5fbfd7..cde87bfd 100644
--- a/lasso/id-ff/logout.c
+++ b/lasso/id-ff/logout.c
@@ -389,7 +389,6 @@ lasso_logout_init_request(LassoLogout    *logout,
   xmlChar           *content        = NULL, *nameQualifier = NULL, *format = NULL;
   xmlChar           *singleLogoutProtocolProfile = NULL;
   GError            *err = NULL;
-  lassoSignatureType signature_type = lassoSignatureTypeNone;
   gint               ret = 0;
   
   /* FIXME : should use a var to know if the protocol profile is SOAP or HTTP GET ? */
@@ -1000,9 +999,12 @@ lasso_logout_validate_request(LassoLogout *logout)
   /* authentication is ok, federation is ok, propagation support is ok, remove federation */
   lasso_session_remove_assertion(profile->session, profile->remote_providerID);
 
-  /* if at IDP and nb sp logged > 1, then backup remote provider id, request and response */
-  /* REMARK : if only initial service provider was logged, then profile->session->providerIDs->len == 0,
-  /*                                                       else profile->session->providerIDs->len >= 1 */
+  /* if at IDP and nb sp logged > 1, then backup remote provider id,
+   * request and response
+   * REMARK : if only initial service provider was logged,
+   *   then profile->session->providerIDs->len == 0,
+   *   else profile->session->providerIDs->len >= 1
+   */
   if (profile->provider_type == lassoProviderTypeIdp && profile->session->providerIDs->len >= 1) {
     logout->initial_remote_providerID = profile->remote_providerID;
     logout->initial_request = profile->request;
@@ -1142,7 +1144,7 @@ lasso_logout_new_from_dump(LassoServer *server,
   LassoProfile *profile;
   LassoNode    *node_dump, *request_node, *response_node;
   LassoNode    *initial_request_node, *initial_response_node;
-  gchar        *type, *export, *initial_remote_providerID, *providerID_index_str;
+  gchar        *type, *export, *providerID_index_str;
 
   g_return_val_if_fail(LASSO_IS_SERVER(server), NULL);
   g_return_val_if_fail(dump != NULL, NULL);
diff --git a/lasso/id-ff/name_registration.c b/lasso/id-ff/name_registration.c
index dd8b5b58..4c7cfcf8 100644
--- a/lasso/id-ff/name_registration.c
+++ b/lasso/id-ff/name_registration.c
@@ -23,6 +23,9 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
+#include <string.h>
+#include <glib/gprintf.h>
+
 #include <lasso/environs/name_registration.h>
 
 static GObjectClass *parent_class = NULL;
@@ -120,9 +123,9 @@ lasso_name_registration_build_request_msg(LassoNameRegistration *name_registrati
 	   xmlStrEqual(protocolProfile,lassoLibProtocolProfileRniSpHttp)) {
     /* temporary vars to store url, query and separator */
     gchar *url, *query;
-    const gchar *separator = "?";
 
-    /* build and optionaly sign the query message and build the register name identifier request url */
+    /* build and optionaly sign the query message and build the register name
+     * identifier request url */
     url = lasso_provider_get_registerNameIdentifierServiceURL(provider, profile->provider_type, NULL);
     query = lasso_node_export_to_query(profile->request,
 				       profile->server->signature_method,
diff --git a/lasso/id-ff/server.c b/lasso/id-ff/server.c
index 8acfb129..e3f9ebbf 100644
--- a/lasso/id-ff/server.c
+++ b/lasso/id-ff/server.c
@@ -127,7 +127,7 @@ gchar *
 lasso_server_dump(LassoServer *server)
 {
   LassoProvider  *provider;
-  LassoNode      *server_node, *providers_node, *provider_node, *metadata_copy, *metadata_node, *entity_node;
+  LassoNode      *server_node, *providers_node, *provider_node, *metadata_copy, *metadata_node;
   LassoNodeClass *metadata_class, *server_class, *providers_class;
   xmlChar        *signature_method_str, *dump;
   gint            i;
diff --git a/lasso/id-ff/session.c b/lasso/id-ff/session.c
index e92cf3bc..e3f942c4 100644
--- a/lasso/id-ff/session.c
+++ b/lasso/id-ff/session.c
@@ -258,8 +258,6 @@ lasso_session_get_provider_index(LassoSession *session,
 {
   gchar *providerID;
 
-  LassoNode *assertion;
-
   g_return_val_if_fail(session != NULL, NULL);
   g_return_val_if_fail(providerID != NULL, NULL);