a bit late; fixed use of unitialized variables (-Wuninitialized needs -O)

5 files changed, 10 insertions, 9 deletions

diff --git a/lasso/id-ff/defederation.c b/lasso/id-ff/defederation.c
index 83a0f22f..8449daba 100644
--- a/lasso/id-ff/defederation.c
+++ b/lasso/id-ff/defederation.c
@@ -64,7 +64,7 @@ lasso_defederation_build_notification_msg(LassoDefederation *defederation)
 {
   LassoProfile      *profile;
   LassoProvider     *provider;
-  xmlChar           *protocolProfile;
+  xmlChar           *protocolProfile = NULL;
   gchar             *url = NULL, *query = NULL;
   lassoProviderType  remote_provider_type;
   gint               ret = 0;
@@ -192,7 +192,7 @@ lasso_defederation_init_notification(LassoDefederation *defederation,
 {
   LassoProfile    *profile;
   LassoProvider   *provider;
-  LassoFederation *federation;
+  LassoFederation *federation = NULL;
   LassoNode       *nameIdentifier = NULL;
   xmlChar         *content = NULL, *nameQualifier = NULL, *format = NULL;
   xmlChar         *federationTerminationProtocolProfile;
@@ -442,8 +442,8 @@ lasso_defederation_validate_notification(LassoDefederation *defederation)
 {
   LassoProfile    *profile;
   LassoProvider   *provider;
-  LassoFederation *federation;
-  LassoNode       *nameIdentifier;
+  LassoFederation *federation = NULL;
+  LassoNode       *nameIdentifier = NULL;
   gint             ret = 0;
   gint            remote_provider_type;
 
diff --git a/lasso/id-ff/login.c b/lasso/id-ff/login.c
index 8e5d85b7..0fd48b3d 100644
--- a/lasso/id-ff/login.c
+++ b/lasso/id-ff/login.c
@@ -133,7 +133,7 @@ lasso_login_process_federation(LassoLogin *login)
 {
   LassoFederation *federation;
   LassoNode *nameIdentifier;
-  xmlChar *id, *nameIDPolicy, *consent;
+  xmlChar *id, *nameIDPolicy, *consent = NULL;
   gint ret = 0;
   GError *err = NULL;
 
@@ -327,7 +327,7 @@ gint
 lasso_login_accept_sso(LassoLogin *login)
 {
   LassoNode *assertion = NULL;
-  LassoNode *ni;
+  LassoNode *ni = NULL;
   LassoNode *idp_ni, *idp_ni_copy = NULL;
   LassoFederation *federation = NULL;
   gint ret = 0;
@@ -1386,7 +1386,7 @@ lasso_login_new_from_dump(LassoServer *server,
 			  gchar       *dump)
 {
   LassoLogin *login;
-  LassoNode *node_dump, *request_node, *response_node;
+  LassoNode *node_dump, *request_node = NULL, *response_node = NULL;
   gchar *protocolProfile, *export, *type;
 
   /* nico : assertion vars */
diff --git a/lasso/id-ff/logout.c b/lasso/id-ff/logout.c
index cde87bfd..c82320f6 100644
--- a/lasso/id-ff/logout.c
+++ b/lasso/id-ff/logout.c
@@ -844,7 +844,7 @@ gint
 lasso_logout_validate_request(LassoLogout *logout)
 {
   LassoProfile    *profile;
-  LassoFederation *federation;
+  LassoFederation *federation = NULL;
   LassoNode       *nameIdentifier, *assertion;
   LassoNode       *statusCode;
   LassoNodeClass  *statusCode_class;
diff --git a/lasso/id-ff/session.c b/lasso/id-ff/session.c
index 6f3276fc..36b4df51 100644
--- a/lasso/id-ff/session.c
+++ b/lasso/id-ff/session.c
@@ -263,7 +263,6 @@ lasso_session_get_provider_index(LassoSession *session,
   gchar *providerID;
 
   g_return_val_if_fail(session != NULL, NULL);
-  g_return_val_if_fail(providerID != NULL, NULL);
 
   /* verify index is valid */
   if ( (session->providerIDs == NULL) && (session->providerIDs->len < 0) ) {
diff --git a/lasso/xml/xml.c b/lasso/xml/xml.c
index e7cbb54d..9adb0ddb 100644
--- a/lasso/xml/xml.c
+++ b/lasso/xml/xml.c
@@ -1430,6 +1430,8 @@ lasso_node_impl_add_signature_tmpl(LassoNode            *node,
     signature = xmlSecTmplSignatureCreate(doc, xmlSecTransformExclC14NId,
 					  xmlSecTransformDsaSha1Id, NULL);
     break;
+  default:
+    signature = NULL;
   }
  
   if (signature == NULL) {