summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Dauvergne <bdauvergne@entrouvert.com>2009-08-26 15:15:24 +0000
committerBenjamin Dauvergne <bdauvergne@entrouvert.com>2009-08-26 15:15:24 +0000
commit29de608d19283c45ff0cc5aa370c24df491e9cac (patch)
tree0721c99e7e22044842a6c3febcc6547ce65b9cf7
parentfa8e5d4679b0ac110e7952e39a5a48311a54489f (diff)
SAML 2.0: Fix bug introduced in commit 4235
* lasso/saml-2.0/login.c: profile->msg_url is released before being used ;( Restore the code copying the URL before passing it to lasso_saml20_profile_build_http_redirect, to free it after.
-rw-r--r--lasso/saml-2.0/login.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/lasso/saml-2.0/login.c b/lasso/saml-2.0/login.c
index 76ef4e0f..cad38187 100644
--- a/lasso/saml-2.0/login.c
+++ b/lasso/saml-2.0/login.c
@@ -1338,9 +1338,11 @@ lasso_saml20_login_build_authn_response_msg(LassoLogin *login)
lasso_assign_new_string(profile->msg_body, lasso_node_export_to_base64(LASSO_NODE(profile->response)));
} else {
int rc;
+ char *acsUrl;
- lasso_release_string(profile->msg_url);
- rc = lasso_saml20_profile_build_http_redirect(profile, profile->response, 1, profile->msg_url);
+ acsUrl = profile->msg_url;
+ rc = lasso_saml20_profile_build_http_redirect(profile, profile->response, 1, acsUrl);
+ lasso_release_string(acsUrl);
if (rc != 0) {
return rc;
}