diff options
| author | Greg Hudson <ghudson@mit.edu> | 2012-11-28 20:19:37 -0500 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2012-11-29 01:59:17 -0500 |
| commit | d31794d43d04d592d079a08dc3cc4ce7164c0df0 (patch) | |
| tree | e139d9242cdd9a9214d1117ed28c922dbfde39e9 /src | |
| parent | 2b06a22f7fd8ec01fb27a7335125290b8ceb6f18 (diff) | |
| download | krb5-d31794d43d04d592d079a08dc3cc4ce7164c0df0.tar.gz krb5-d31794d43d04d592d079a08dc3cc4ce7164c0df0.tar.xz krb5-d31794d43d04d592d079a08dc3cc4ce7164c0df0.zip | |
Avoid redundant socket cleanup in sendto_kdc.c
Since r25120, kill_conn() has been responsible for closing and
invalidating conn->fd. In the unlikely event that the KDC sends a TCP
response to us before we send a TCP request, we were cleaning up the
socket again, which is useless (though also harmless). Get rid of
that code.
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/krb5/os/sendto_kdc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c index 22cd90812..d8b6a9596 100644 --- a/src/lib/krb5/os/sendto_kdc.c +++ b/src/lib/krb5/os/sendto_kdc.c @@ -963,10 +963,6 @@ service_tcp_fd(krb5_context context, struct conn_state *conn, kill_conn: TRACE_SENDTO_KDC_TCP_DISCONNECT(context, conn); kill_conn(conn, selstate, e); - if (e == EINVAL) { - closesocket(conn->fd); - conn->fd = INVALID_SOCKET; - } return e == 0; } if (ssflags & SSF_EXCEPTION) { |