diff options
| author | Greg Hudson <ghudson@mit.edu> | 2009-02-23 20:15:05 +0000 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2009-02-23 20:15:05 +0000 |
| commit | 70027238e1b53ea20b0297ffca72a48d1627b121 (patch) | |
| tree | f409e7d074c3860092e6e2d5a2943b2e31767cf9 /src | |
| parent | b1c1b4eb0a62f5d508e1e890706f83309386bc5f (diff) | |
| download | krb5-70027238e1b53ea20b0297ffca72a48d1627b121.tar.gz krb5-70027238e1b53ea20b0297ffca72a48d1627b121.tar.xz krb5-70027238e1b53ea20b0297ffca72a48d1627b121.zip | |
In krb5int_generate_and_save_subkey, check the return value of
krb5_crypto_us_timeofday. It can't really fail in practice, but if it
did we'd be passing stack garbage to krb5_c_random_add_entropy.
That's harmless, but poor form.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22049 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/krb5/krb/mk_req_ext.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/lib/krb5/krb/mk_req_ext.c b/src/lib/krb5/krb/mk_req_ext.c index ed23fef4b..2cf1ddf13 100644 --- a/src/lib/krb5/krb/mk_req_ext.c +++ b/src/lib/krb5/krb/mk_req_ext.c @@ -94,10 +94,11 @@ krb5int_generate_and_save_subkey (krb5_context context, krb5_data d; krb5_error_code retval; - krb5_crypto_us_timeofday (&rnd_data.sec, &rnd_data.usec); - d.length = sizeof (rnd_data); - d.data = (char *) &rnd_data; - (void) krb5_c_random_add_entropy (context, KRB5_C_RANDSOURCE_TIMING, &d); + if (krb5_crypto_us_timeofday(&rnd_data.sec, &rnd_data.usec) == 0) { + d.length = sizeof(rnd_data); + d.data = (char *) &rnd_data; + krb5_c_random_add_entropy(context, KRB5_C_RANDSOURCE_TIMING, &d); + } if (auth_context->send_subkey) krb5_free_keyblock(context, auth_context->send_subkey); |