diff options
| author | Ezra Peisach <epeisach@mit.edu> | 2006-12-18 11:26:59 +0000 |
|---|---|---|
| committer | Ezra Peisach <epeisach@mit.edu> | 2006-12-18 11:26:59 +0000 |
| commit | 45adade7736d99462e60694df87ba28eb5753b4f (patch) | |
| tree | 69cde62a1a36f0410bbca4c7ebe51f3228e2c20d /src | |
| parent | 13837d7af7682c0f59c9fc402870a875dded3285 (diff) | |
| download | krb5-45adade7736d99462e60694df87ba28eb5753b4f.tar.gz krb5-45adade7736d99462e60694df87ba28eb5753b4f.tar.xz krb5-45adade7736d99462e60694df87ba28eb5753b4f.zip | |
krb5_rc_io_open_internal on error will call close(-1)
If there is an error in opening the replay cache - memory is freed, but
close() is invoked with -1 (failure from open()). While technically,
close() will return EBADF in such a case, and nothing bad will happen,
valgrind picks up on this and provides an error...
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18961 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/krb5/rcache/rc_io.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/lib/krb5/rcache/rc_io.c b/src/lib/krb5/rcache/rc_io.c index 8453d1832..adc6a8c49 100644 --- a/src/lib/krb5/rcache/rc_io.c +++ b/src/lib/krb5/rcache/rc_io.c @@ -168,7 +168,9 @@ krb5_rc_io_creat(krb5_context context, krb5_rc_iostuff *d, char **fn) FREE(d->fn); d->fn = NULL; } - (void) close(d->fd); + if (d->fd != -1) { + (void) close(d->fd); + } } return retval; } |