* utility.c: Add casts on types being sent to internal functions

        * krb5_encode_test.c: Declare internal functions as static.

        * ktest.c: Remove unused functions. Clean up compiler warnings.

        * trval.c: Add proper prototype for declared functions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@12590 dc483132-0cff-0310-8789-dd5450dbe970

1 files changed, 3 insertions, 3 deletions

diff --git a/src/tests/asn.1/utility.c b/src/tests/asn.1/utility.c
index 739d63913..0831a0864 100644
--- a/src/tests/asn.1/utility.c
+++ b/src/tests/asn.1/utility.c
@@ -22,11 +22,11 @@ asn1_error_code asn1_krb5_data_unparse(code, s)
   }else{
     int i;
 
-    *s = (char*)calloc(3*(code->length), sizeof(char));
+    *s = (char*)calloc((size_t) 3*(code->length), sizeof(char));
     if(*s == NULL) return ENOMEM;
     for(i = 0; i < code->length; i++){
-      (*s)[3*i] = hexchar(((code->data)[i]&0xF0)>>4);
-      (*s)[3*i+1] = hexchar((code->data)[i]&0x0F);
+      (*s)[3*i] = hexchar((unsigned char) (((code->data)[i]&0xF0)>>4));
+      (*s)[3*i+1] = hexchar((unsigned char) ((code->data)[i]&0x0F));
       (*s)[3*i+2] = ' ';
     }
     (*s)[3*(code->length)-1] = '\0';