diff options
| author | Sam Hartman <hartmans@mit.edu> | 2003-01-05 23:28:05 +0000 |
|---|---|---|
| committer | Sam Hartman <hartmans@mit.edu> | 2003-01-05 23:28:05 +0000 |
| commit | 8b090d247a059021fb84c6962a43e91d2e4ab964 (patch) | |
| tree | 2c589e72f112e062181992474d1c4b62ec44ca17 /src/lib | |
| parent | 90d160520f5bce129c9a3ea1f22370a740e11136 (diff) | |
Only system headers should declare errno
Many parts of krb5 declare errno in source files using extern int
errno. This has not been needed in ANSI C for a long time,
and actively breaks modern versions of glibc.
So these declarations are removed and errno.h included where necessary.
Ticket: new
Component: krb5-build
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15082 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/kadm5/srv/ChangeLog | 6 | ||||
| -rw-r--r-- | src/lib/kadm5/srv/adb_policy.c | 2 | ||||
| -rw-r--r-- | src/lib/kadm5/srv/server_dict.c | 3 | ||||
| -rw-r--r-- | src/lib/krb4/ChangeLog | 6 | ||||
| -rw-r--r-- | src/lib/krb4/dest_tkt.c | 1 | ||||
| -rw-r--r-- | src/lib/krb4/tf_util.c | 1 | ||||
| -rw-r--r-- | src/lib/krb5/posix/ChangeLog | 4 | ||||
| -rw-r--r-- | src/lib/krb5/posix/syslog.c | 2 | ||||
| -rw-r--r-- | src/lib/rpc/ChangeLog | 7 | ||||
| -rw-r--r-- | src/lib/rpc/clnt_udp.c | 2 | ||||
| -rw-r--r-- | src/lib/rpc/pmap_getmaps.c | 1 | ||||
| -rw-r--r-- | src/lib/rpc/pmap_rmt.c | 1 | ||||
| -rw-r--r-- | src/lib/rpc/svc_auth_gssapi.c | 2 | ||||
| -rw-r--r-- | src/lib/rpc/svc_run.c | 3 | ||||
| -rw-r--r-- | src/lib/rpc/svc_udp.c | 1 |
15 files changed, 30 insertions, 12 deletions
diff --git a/src/lib/kadm5/srv/ChangeLog b/src/lib/kadm5/srv/ChangeLog index 22e1d2d4e..106c2bee7 100644 --- a/src/lib/kadm5/srv/ChangeLog +++ b/src/lib/kadm5/srv/ChangeLog @@ -1,3 +1,9 @@ +2003-01-05 Sam Hartman <hartmans@mit.edu> + + * server_dict.c: Remove declaration of errno + + * adb_policy.c: Remove declaration of errno + 2002-12-16 Ezra Peisach <epeisach@bu.edu> * Makefile.in: Change to allow compilation with-system-db and diff --git a/src/lib/kadm5/srv/adb_policy.c b/src/lib/kadm5/srv/adb_policy.c index 7403d31a7..f081551d7 100644 --- a/src/lib/kadm5/srv/adb_policy.c +++ b/src/lib/kadm5/srv/adb_policy.c @@ -13,8 +13,8 @@ static char *rcsid = "$Header$"; #include "adb.h" #include <stdlib.h> #include <string.h> +#include <errno.h> -extern int errno; #define OPENLOCK(db, mode) \ { \ diff --git a/src/lib/kadm5/srv/server_dict.c b/src/lib/kadm5/srv/server_dict.c index 5b718d484..53df800b9 100644 --- a/src/lib/kadm5/srv/server_dict.c +++ b/src/lib/kadm5/srv/server_dict.c @@ -13,6 +13,7 @@ static char *rcsid = "$Header$"; #include <fcntl.h> #include <sys/stat.h> #include <unistd.h> +#include <errno.h> #include <kadm5/admin.h> #include <stdlib.h> #include <stdio.h> @@ -27,7 +28,7 @@ static char *rcsid = "$Header$"; static char **word_list = NULL; /* list of word pointers */ static char *word_block = NULL; /* actual word data */ static unsigned int word_count = 0; /* number of words */ -extern int errno; + /* * Function: word_compare diff --git a/src/lib/krb4/ChangeLog b/src/lib/krb4/ChangeLog index bff5f1c09..0b0a976c8 100644 --- a/src/lib/krb4/ChangeLog +++ b/src/lib/krb4/ChangeLog @@ -1,3 +1,9 @@ +2003-01-05 Sam Hartman <hartmans@mit.edu> + + * tf_util.c: Remove declaration of errno + + * dest_tkt.c (dest_tkt): Remove declaration of errno + 2002-12-18 Tom Yu <tlyu@mit.edu> * RealmsConfig-glue.c: Fix up KRB5_CALLCONV. diff --git a/src/lib/krb4/dest_tkt.c b/src/lib/krb4/dest_tkt.c index 5fd234443..676302509 100644 --- a/src/lib/krb4/dest_tkt.c +++ b/src/lib/krb4/dest_tkt.c @@ -69,7 +69,6 @@ dest_tkt() { const char *file = TKT_FILE; int i,fd; - extern int errno; int ret; struct stat statpre, statpost; char buf[BUFSIZ]; diff --git a/src/lib/krb4/tf_util.c b/src/lib/krb4/tf_util.c index 7de4b0ac4..6cb9eeb8f 100644 --- a/src/lib/krb4/tf_util.c +++ b/src/lib/krb4/tf_util.c @@ -47,7 +47,6 @@ #define TF_LCK_RETRY ((unsigned)2) /* seconds to sleep before * retry if ticket file is * locked */ -extern int errno; extern int krb_debug; void tf_close(); diff --git a/src/lib/krb5/posix/ChangeLog b/src/lib/krb5/posix/ChangeLog index 8112eb1d7..0a2cb1c81 100644 --- a/src/lib/krb5/posix/ChangeLog +++ b/src/lib/krb5/posix/ChangeLog @@ -1,3 +1,7 @@ +2003-01-05 Sam Hartman <hartmans@mit.edu> + + * syslog.c (vsyslog): Remove declaration of errno + 2002-08-29 Ken Raeburn <raeburn@mit.edu> * Makefile.in: Revert $(S)=>/ change, for Windows support. diff --git a/src/lib/krb5/posix/syslog.c b/src/lib/krb5/posix/syslog.c index 7188e36f9..3a02e8425 100644 --- a/src/lib/krb5/posix/syslog.c +++ b/src/lib/krb5/posix/syslog.c @@ -41,6 +41,7 @@ #define const #include <varargs.h> #endif +#include <errno.h> #include <sys/types.h> #include <sys/socket.h> #include <sys/file.h> @@ -89,7 +90,6 @@ vsyslog(pri, fmt, ap) const register char *fmt; va_list ap; { - extern int errno; register int cnt; register char *p; time_t now, time(); diff --git a/src/lib/rpc/ChangeLog b/src/lib/rpc/ChangeLog index 2a8bfe579..a3be9154c 100644 --- a/src/lib/rpc/ChangeLog +++ b/src/lib/rpc/ChangeLog @@ -1,3 +1,10 @@ +2003-01-05 Sam Hartman <hartmans@mit.edu> + + * svc_run.c svc_udp.c : Remove declaration of errno + + * clnt_udp.c pmap_getmaps.c pmap_rmt.c svc_auth_gssapi.c: Remove + declaration of errno + 2002-12-18 Ken Raeburn <raeburn@mit.edu> * auth_gssapi_misc.c (xdr_gss_buf, auth_gssapi_wrap_data, diff --git a/src/lib/rpc/clnt_udp.c b/src/lib/rpc/clnt_udp.c index 78102269e..6e20e5799 100644 --- a/src/lib/rpc/clnt_udp.c +++ b/src/lib/rpc/clnt_udp.c @@ -48,8 +48,8 @@ static char sccsid[] = "@(#)clnt_udp.c 1.39 87/08/11 Copyr 1984 Sun Micro"; #include <netdb.h> #include <errno.h> #include <gssrpc/pmap_clnt.h> +#include <errno.h> -extern int errno; /* * UDP bases client side rpc operations diff --git a/src/lib/rpc/pmap_getmaps.c b/src/lib/rpc/pmap_getmaps.c index 7f9020617..a4e1f9ca0 100644 --- a/src/lib/rpc/pmap_getmaps.c +++ b/src/lib/rpc/pmap_getmaps.c @@ -56,7 +56,6 @@ static char sccsid[] = "@(#)pmap_getmaps.c 1.10 87/08/11 Copyr 1984 Sun Micro"; #define NAMELEN 255 #define MAX_BROADCAST_SIZE 1400 -extern int errno; /* * Get a copy of the current port maps. diff --git a/src/lib/rpc/pmap_rmt.c b/src/lib/rpc/pmap_rmt.c index bc71ec060..3e82cea91 100644 --- a/src/lib/rpc/pmap_rmt.c +++ b/src/lib/rpc/pmap_rmt.c @@ -60,7 +60,6 @@ static char sccsid[] = "@(#)pmap_rmt.c 1.21 87/08/27 Copyr 1984 Sun Micro"; #define MAX_BROADCAST_SIZE 1400 #include <string.h> -extern int errno; static struct timeval timeout = { 3, 0 }; diff --git a/src/lib/rpc/svc_auth_gssapi.c b/src/lib/rpc/svc_auth_gssapi.c index d3a634a00..cb2844fc3 100644 --- a/src/lib/rpc/svc_auth_gssapi.c +++ b/src/lib/rpc/svc_auth_gssapi.c @@ -12,6 +12,7 @@ */ #include <stdio.h> +#include <errno.h> #include <string.h> #include <gssrpc/rpc.h> #include <sys/stat.h> @@ -114,7 +115,6 @@ typedef struct _client_list { static client_list *clients = NULL; -extern int errno; enum auth_stat _gssrpc_svcauth_gssapi(rqst, msg, no_dispatch) register struct svc_req *rqst; diff --git a/src/lib/rpc/svc_run.c b/src/lib/rpc/svc_run.c index ca48364a1..823b1d461 100644 --- a/src/lib/rpc/svc_run.c +++ b/src/lib/rpc/svc_run.c @@ -37,7 +37,7 @@ static char sccsid[] = "@(#)svc_run.c 1.1 87/10/13 Copyr 1984 Sun Micro"; * Wait for input, call server program. */ #include <gssrpc/rpc.h> -#include <sys/errno.h> +#include <errno.h> void svc_run() @@ -47,7 +47,6 @@ svc_run() #else int readfds; #endif /* def FD_SETSIZE */ - extern int errno; for (;;) { #ifdef FD_SETSIZE diff --git a/src/lib/rpc/svc_udp.c b/src/lib/rpc/svc_udp.c index 21b5c8f06..a1bcb86a9 100644 --- a/src/lib/rpc/svc_udp.c +++ b/src/lib/rpc/svc_udp.c @@ -74,7 +74,6 @@ static struct xp_ops svcudp_op = { svcudp_destroy }; -extern int errno; /* * kept in xprt->xp_p2 |
