summaryrefslogtreecommitdiffstats
path: root/src/lib/apputils
diff options
context:
space:
mode:
authorGreg Hudson <ghudson@mit.edu>2014-07-03 12:48:53 -0400
committerGreg Hudson <ghudson@mit.edu>2014-07-04 15:14:03 -0400
commit48a0b16ab1f70b6486a6d7af7ca9e7b376b19956 (patch)
treef761ac8f8209fca8708f9f55f8fc5c7b13ce8940 /src/lib/apputils
parent1fde9a67030845d3cae0661595f5737a4db8b9dd (diff)
downloadkrb5-48a0b16ab1f70b6486a6d7af7ca9e7b376b19956.tar.gz
krb5-48a0b16ab1f70b6486a6d7af7ca9e7b376b19956.tar.xz
krb5-48a0b16ab1f70b6486a6d7af7ca9e7b376b19956.zip
Avoid using length fields in socket addresses
Remove code to set or reference the length fields of socket addresses (sa_len/sin_len/sin6_len), since they aren't portable and setting them is not required. Remove autoconf tests for those fields which are no longer used or which were never used. There is one exception: in localaddr.c, we still neeed to reference sa_len for the definition of ifreq_size on platforms which have sa_len. Leave that behind, along with the autoconf test which defines SA_LEN.
Diffstat (limited to 'src/lib/apputils')
-rw-r--r--src/lib/apputils/net-server.c18
1 files changed, 0 insertions, 18 deletions
diff --git a/src/lib/apputils/net-server.c b/src/lib/apputils/net-server.c
index 558eee34c..1ad64141c 100644
--- a/src/lib/apputils/net-server.c
+++ b/src/lib/apputils/net-server.c
@@ -708,16 +708,10 @@ setup_tcp_listener_ports(struct socksetup *data)
memset(&sin4, 0, sizeof(sin4));
sin4.sin_family = AF_INET;
-#ifdef HAVE_SA_LEN
- sin4.sin_len = sizeof(sin4);
-#endif
sin4.sin_addr.s_addr = INADDR_ANY;
memset(&sin6, 0, sizeof(sin6));
sin6.sin6_family = AF_INET6;
-#ifdef SIN6_LEN
- sin6.sin6_len = sizeof(sin6);
-#endif
sin6.sin6_addr = in6addr_any;
FOREACH_ELT (tcp_port_data, i, port) {
@@ -776,16 +770,10 @@ setup_rpc_listener_ports(struct socksetup *data)
memset(&sin4, 0, sizeof(sin4));
sin4.sin_family = AF_INET;
-#ifdef HAVE_SA_LEN
- sin4.sin_len = sizeof(sin4);
-#endif
sin4.sin_addr.s_addr = INADDR_ANY;
memset(&sin6, 0, sizeof(sin6));
sin6.sin6_family = AF_INET6;
-#ifdef HAVE_SA_LEN
- sin6.sin6_len = sizeof(sin6);
-#endif
sin6.sin6_addr = in6addr_any;
FOREACH_ELT (rpc_svc_data, i, svc) {
@@ -846,9 +834,6 @@ setup_udp_pktinfo_ports(struct socksetup *data)
memset(&sa, 0, sizeof(sa));
sa.sin_family = AF_INET;
-#ifdef HAVE_SA_LEN
- sa.sin_len = sizeof(sa);
-#endif
r = setup_udp_port_1(data, (struct sockaddr *)&sa, 4);
if (r == 0)
data->do_ipv4_udp_all = FALSE;
@@ -861,9 +846,6 @@ setup_udp_pktinfo_ports(struct socksetup *data)
memset(&sa, 0, sizeof(sa));
sa.sin6_family = AF_INET6;
-#ifdef HAVE_SA_LEN
- sa.sin6_len = sizeof(sa);
-#endif
r = setup_udp_port_1(data, (struct sockaddr *)&sa, 6);
if (r == 0)
data->do_ipv6_udp_all = FALSE;