diff options
author | Greg Hudson <ghudson@mit.edu> | 2011-10-28 16:18:45 +0000 |
---|---|---|
committer | Greg Hudson <ghudson@mit.edu> | 2011-10-28 16:18:45 +0000 |
commit | 8d54c72ae291cea5c68f810ebe7629520e395105 (patch) | |
tree | 48904b6525bc614e4527ac0faa7fd9a3296a37ec /src/kdc/do_as_req.c | |
parent | 6fd903e14fa9b73c2c312c3d6af383a7356ebc5a (diff) | |
download | krb5-8d54c72ae291cea5c68f810ebe7629520e395105.tar.gz krb5-8d54c72ae291cea5c68f810ebe7629520e395105.tar.xz krb5-8d54c72ae291cea5c68f810ebe7629520e395105.zip |
Use zero-filled states for all async ops in KDC
There have been a couple of uninitialized field bugs in the
restructured KDC code, partly because compilers can't find these bugs
as easily as they can find uninitialized local variable bugs. Use
zero-filled state structures to make this type of bug less likely.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25422 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/kdc/do_as_req.c')
-rw-r--r-- | src/kdc/do_as_req.c | 25 |
1 files changed, 3 insertions, 22 deletions
diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c index e09baf9ed..0d5cbe515 100644 --- a/src/kdc/do_as_req.c +++ b/src/kdc/do_as_req.c @@ -460,35 +460,16 @@ process_as_req(krb5_kdc_req *request, krb5_data *req_pkt, krb5_enctype useenctype; struct as_req_state *state; - state = malloc(sizeof(*state)); - if (!state) { - (*respond)(arg, ENOMEM, NULL); + state = k5alloc(sizeof(*state), &errcode); + if (state == NULL) { + (*respond)(arg, errcode, NULL); return; } - state->session_key.contents = 0; - state->enc_tkt_reply.authorization_data = NULL; - state->reply.padata = 0; - memset(&state->reply, 0, sizeof(state->reply)); state->respond = respond; state->arg = arg; - state->ticket_reply.enc_part.ciphertext.data = 0; - state->server_keyblock.contents = NULL; - state->client_keyblock.contents = NULL; - state->reply_encpart.enc_padata = 0; - state->client = NULL; - state->server = NULL; state->request = request; - state->e_data = NULL; - state->typed_e_data = FALSE; - state->authtime = 0; - state->c_flags = 0; state->req_pkt = req_pkt; - state->rstate = NULL; - state->sname = 0; - state->cname = 0; - state->pa_context = NULL; state->from = from; - memset(&state->rock, 0, sizeof(state->rock)); #if APPLE_PKINIT asReqDebug("process_as_req top realm %s name %s\n", |