diff options
| author | Alexandra Ellwood <lxs@mit.edu> | 2008-10-10 20:55:24 +0000 |
|---|---|---|
| committer | Alexandra Ellwood <lxs@mit.edu> | 2008-10-10 20:55:24 +0000 |
| commit | 6cee5c1cd0f5f228bf9d677c77114ec0488163fd (patch) | |
| tree | e54b8daf3c1880278446964dccf892d43f167701 | |
| parent | c19c1cb84f7d2cc221ee65f2ed5ff4543cb20b07 (diff) | |
| download | krb5-6cee5c1cd0f5f228bf9d677c77114ec0488163fd.tar.gz krb5-6cee5c1cd0f5f228bf9d677c77114ec0488163fd.tar.xz krb5-6cee5c1cd0f5f228bf9d677c77114ec0488163fd.zip | |
always zero out authentication strings
strings returned by the UI are usually passwords or pins
and should not get dripped all over memory.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20863 dc483132-0cff-0310-8789-dd5450dbe970
| -rw-r--r-- | src/kim/lib/kim_ui.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/kim/lib/kim_ui.c b/src/kim/lib/kim_ui.c index ccc59f440..e52cd9bb2 100644 --- a/src/kim/lib/kim_ui.c +++ b/src/kim/lib/kim_ui.c @@ -319,9 +319,9 @@ krb5_error_code kim_ui_prompter (krb5_context in_krb5_context, /* Clean up reply buffer. Saved passwords are allocated by KIM. */ if (reply) { - memset (reply, '\0', strlen (reply)); - if (got_saved_password) { - kim_string_free ((kim_string *) &reply); + if (got_saved_password) { + memset (reply, '\0', strlen (reply)); + kim_string_free ((kim_string *) &reply); } else { kim_ui_free_string (context, &reply); } @@ -445,6 +445,9 @@ void kim_ui_free_string (kim_ui_context *in_context, kim_error err = kim_ui_init_lazy (in_context); if (!err && in_context && io_string && *io_string) { + /* most ui strings are auth information so zero before freeing */ + memset (*io_string, '\0', strlen (*io_string)); + if (in_context->type == kim_ui_type_gui_plugin) { kim_ui_plugin_free_string (in_context, io_string); |