diff options
| author | Ezra Peisach <epeisach@mit.edu> | 2009-04-07 17:57:56 +0000 |
|---|---|---|
| committer | Ezra Peisach <epeisach@mit.edu> | 2009-04-07 17:57:56 +0000 |
| commit | 324affc316edff9bf690c05a18fb18167c562ca1 (patch) | |
| tree | 6ab016b37eba91047ecb8261355bd4a4a38f346e | |
| parent | 427b73f0c2e2c1278ae9dddfa18a35d01fd85a8d (diff) | |
| download | krb5-324affc316edff9bf690c05a18fb18167c562ca1.tar.gz krb5-324affc316edff9bf690c05a18fb18167c562ca1.tar.xz krb5-324affc316edff9bf690c05a18fb18167c562ca1.zip | |
Null pointer defref in adding info
Clearly the code is broken - and we either never use it - or callers never pass
NULL...
Detected by clang static checker.
ticket: 6442
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22172 dc483132-0cff-0310-8789-dd5450dbe970
| -rw-r--r-- | src/util/ss/help.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/util/ss/help.c b/src/util/ss/help.c index 10b1c1075..981a75fab 100644 --- a/src/util/ss/help.c +++ b/src/util/ss/help.c @@ -107,7 +107,7 @@ void ss_add_info_dir(sci_idx, info_dir, code_ptr) register char **dirs; info = ss_info(sci_idx); - if (info_dir == NULL && *info_dir) { + if ((info_dir == NULL) || (*info_dir == '\0')) { *code_ptr = SS_ET_NO_INFO_DIR; return; } |