summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeffrey Altman <jaltman@secure-endpoints.com>2004-05-15 12:57:05 +0000
committerJeffrey Altman <jaltman@secure-endpoints.com>2004-05-15 12:57:05 +0000
commit17c9ec23a7252c27b2faaa9cbae8e6d9751ba0ee (patch)
treedcf54e3cf2f414ab73f4b79667fd5e0b6f14a61a
parent40ea20074a236fc123a3a6ee5fa03d20a2e5c7c0 (diff)
downloadkrb5-17c9ec23a7252c27b2faaa9cbae8e6d9751ba0ee.tar.gz
krb5-17c9ec23a7252c27b2faaa9cbae8e6d9751ba0ee.tar.xz
krb5-17c9ec23a7252c27b2faaa9cbae8e6d9751ba0ee.zip
The memory allocated by ConstructTicketRequest is not LSA memory
and must be freed with LocalFree(). ticket: 2561 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16339 dc483132-0cff-0310-8789-dd5450dbe970
-rw-r--r--src/lib/krb5/ccache/ChangeLog3
-rw-r--r--src/lib/krb5/ccache/cc_mslsa.c2
2 files changed, 3 insertions, 2 deletions
diff --git a/src/lib/krb5/ccache/ChangeLog b/src/lib/krb5/ccache/ChangeLog
index aabd2f29a..6d469a50a 100644
--- a/src/lib/krb5/ccache/ChangeLog
+++ b/src/lib/krb5/ccache/ChangeLog
@@ -3,7 +3,8 @@
* cc_mslsa.c: The FAILED() macro only considered an error
to be a failure if the value is negative. ConstructTicketRequest()
returns positive errors. Do not use FAILED() to test the result.
- Also, fix a potential leak of LSA allocated memory.
+ Fix a potential leak of LSA allocated memory. Fix a leak of
+ LocalAlloc memory.
2004-04-24 Ken Raeburn <raeburn@mit.edu>
diff --git a/src/lib/krb5/ccache/cc_mslsa.c b/src/lib/krb5/ccache/cc_mslsa.c
index 73d6b7096..93a938d82 100644
--- a/src/lib/krb5/ccache/cc_mslsa.c
+++ b/src/lib/krb5/ccache/cc_mslsa.c
@@ -854,7 +854,7 @@ GetMSTGT(HANDLE LogonHandle, ULONG PackageId,KERB_EXTERNAL_TICKET **ticket)
cleanup:
if ( pTicketRequest )
- LsaFreeReturnBuffer(pTicketRequest);
+ LocalFree(pTicketRequest);
if (FAILED(Status) || FAILED(SubStatus))
{