summaryrefslogtreecommitdiffstats
path: root/ipsilon/login/authform.py
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2015-05-07 12:33:40 -0400
committerSimo Sorce <simo@redhat.com>2015-05-07 14:29:49 -0400
commitd8aa3e10398d0d23eefdbda899475ca32ec3abf6 (patch)
treef17e5fb0f9f0a1a922bcbd80ec798396c508f56d /ipsilon/login/authform.py
parent93d4e52712767fe955f3a44a60a6c6f0f909423b (diff)
downloadipsilon-pylint143.tar.gz
ipsilon-pylint143.tar.xz
ipsilon-pylint143.zip
pylint 1.4.3 version fixespylint143
Pylint 1.4.3 completely stopped recognizing the star-args condition. In order to avoid pylint error with > 1.4.3 stop caring for star-args and add cmdline option to ignore those errors completly so older pylint versions are happy too. Also fix type() vs isinstance() checks, isinstance is generally a more correct approach to check for calsses. In some 'admin' files the type() -> isinstance() fix required to invert the order in which ComplexList and MappingList are checked as the latter is a subclass of ComplexList, so it needs to be checked first otherwise the check for isinstance(option, ComplexList) matches for both and the code stops funciotning properly. Signed-off-by: Simo Sorce <simo@redhat.com>
Diffstat (limited to 'ipsilon/login/authform.py')
-rw-r--r--ipsilon/login/authform.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/ipsilon/login/authform.py b/ipsilon/login/authform.py
index ecce919..0e20a60 100644
--- a/ipsilon/login/authform.py
+++ b/ipsilon/login/authform.py
@@ -123,7 +123,7 @@ class Installer(LoginManagerInstaller):
'service': opts['form_service']}
tmpl = Template(CONF_TEMPLATE)
- hunk = tmpl.substitute(**confopts) # pylint: disable=star-args
+ hunk = tmpl.substitute(**confopts)
with open(opts['httpd_conf'], 'a') as httpd_conf:
httpd_conf.write(hunk)