summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2015-03-28 12:49:54 +0100
committerSimo Sorce <simo@redhat.com>2015-03-29 17:30:43 -0400
commitdd20a1265ed3c007dd12b10743b25d40c98992a6 (patch)
treebff4a7c8e28c93fca3c73d4ea3114d4fb0011787
parent3ea42efe873859745e4b4199be6bf43591798edc (diff)
downloadgss-proxy-dd20a1265ed3c007dd12b10743b25d40c98992a6.tar.gz
gss-proxy-dd20a1265ed3c007dd12b10743b25d40c98992a6.tar.xz
gss-proxy-dd20a1265ed3c007dd12b10743b25d40c98992a6.zip
Fix warning value stored to 'ret' is never read
Error: UNUSED_VALUE src/gp_rpc_import_and_canon_name.c:87: value_overwrite: Overwriting previous write to "ret" with value from "gp_conv_status_to_gssx(&icna->call_ctx, ret_maj, ret_min, mech, &icnr->status)". src/gp_rpc_import_and_canon_name.c:52: assigned_value: Assigning value "22" to "ret" here, but that stored value is overwritten before it can be used. Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com> Reviewed-by: Simo Sorce <simo@redhat.com>
-rw-r--r--proxy/src/gp_rpc_import_and_canon_name.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/proxy/src/gp_rpc_import_and_canon_name.c b/proxy/src/gp_rpc_import_and_canon_name.c
index 1988a8b..5434e22 100644
--- a/proxy/src/gp_rpc_import_and_canon_name.c
+++ b/proxy/src/gp_rpc_import_and_canon_name.c
@@ -49,7 +49,8 @@ int gp_import_and_canon_name(struct gp_call_ctx *gpcall,
if (icna->input_name.display_name.octet_string_len == 0 &&
icna->input_name.exported_name.octet_string_len == 0) {
- ret = EINVAL;
+ ret_maj = GSS_S_FAILURE;
+ ret_min = EINVAL;
goto done;
}