diff options
| author | Robbie Harwood <rharwood@redhat.com> | 2016-05-16 14:50:13 -0400 |
|---|---|---|
| committer | Simo Sorce <simo@redhat.com> | 2016-05-18 12:51:42 -0400 |
| commit | 518e1c10bcfc96fd3164b3eec77baadcc32594b6 (patch) | |
| tree | 9fbfe5677e283f755a7417662e90f298cb632539 | |
| parent | 34501e62a20e114ad8d8f2322265e09d1925680c (diff) | |
Fix return check on gp_conv_gssx_to_name
This bug was found by Coverity.
Merges #25
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Simo Sorce <simo@redhat.com>
| -rw-r--r-- | proxy/src/gp_creds.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/proxy/src/gp_creds.c b/proxy/src/gp_creds.c index 551b020..446c7d8 100644 --- a/proxy/src/gp_creds.c +++ b/proxy/src/gp_creds.c @@ -580,7 +580,9 @@ uint32_t gp_add_krb5_creds(uint32_t *min, } else if (desired_name) { ret_maj = gp_conv_gssx_to_name(&ret_min, desired_name, &req_name); } - if (ret_min) { + if (ret_maj) { + goto done; + } else if (ret_min) { ret_maj = GSS_S_CRED_UNAVAIL; goto done; } |