summaryrefslogtreecommitdiffstats
path: root/util
diff options
context:
space:
mode:
authorMartin Babinsky <mbabinsk@redhat.com>2015-01-28 16:21:15 +0100
committerMartin Kosek <mkosek@redhat.com>2015-01-30 11:02:16 +0100
commit98b1690a0e18f85560c092f8abac5f451bddf2e7 (patch)
tree6816cbc9d6ecf6ce2e77bf83acc8b3ae0e84eaf9 /util
parente29f9280fd33b55c096289e34cd98300f618b5f4 (diff)
downloadfreeipa-98b1690a0e18f85560c092f8abac5f451bddf2e7.tar.gz
freeipa-98b1690a0e18f85560c092f8abac5f451bddf2e7.tar.xz
freeipa-98b1690a0e18f85560c092f8abac5f451bddf2e7.zip
ipa-kdb: unexpected error code in 'ipa_kdb_audit_as_req' triggers a message
This patch is related this defect reported by covscan on FreeIPA master: """ Error: DEADCODE (CWE-561): /daemons/ipa-kdb/ipa_kdb_audit_as.c:42: cond_const: Condition "error_code != -1765328353L", taking false branch. Now the value of "error_code" is equal to -1765328353. /daemons/ipa-kdb/ipa_kdb_audit_as.c:42: cond_const: Condition "error_code != -1765328360L", taking false branch. Now the value of "error_code" is equal to -1765328360. /daemons/ipa-kdb/ipa_kdb_audit_as.c:42: cond_const: Condition "error_code != 0", taking false branch. Now the value of "error_code" is equal to 0. /daemons/ipa-kdb/ipa_kdb_audit_as.c:71: intervals: When switching on "error_code", the value of "error_code" must be in one of the following intervals: {[-1765328360,-1765328360], [-1765328353,-1765328353], [0,0]}. /daemons/ipa-kdb/ipa_kdb_audit_as.c:71: dead_error_condition: The switch value "error_code" cannot reach the default case. /daemons/ipa-kdb/ipa_kdb_audit_as.c:123: dead_error_begin: Execution cannot reach this statement: "default:". """ This patch is a part of series related to https://fedorahosted.org/freeipa/ticket/4795. Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
Diffstat (limited to 'util')
-rw-r--r--util/ipa_krb5.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/util/ipa_krb5.h b/util/ipa_krb5.h
index 7b877aa66..2153bd571 100644
--- a/util/ipa_krb5.h
+++ b/util/ipa_krb5.h
@@ -30,6 +30,8 @@ struct keys_container {
#define KEYTAB_RET_OID "2.16.840.1.113730.3.8.10.2"
#define KEYTAB_GET_OID "2.16.840.1.113730.3.8.10.5"
+int krb5_klog_syslog(int, const char *, ...);
+
void
ipa_krb5_free_ktypes(krb5_context context, krb5_enctype *val);