diff options
| author | Martin Basti <mbasti@redhat.com> | 2016-04-08 16:18:08 +0200 |
|---|---|---|
| committer | Martin Basti <mbasti@redhat.com> | 2016-04-22 13:28:57 +0200 |
| commit | fe2ce02a6f7664e377c367e16e9c2e1ad960c9d7 (patch) | |
| tree | b33ddc969e00ad6565b982bec11eba392e8ab4ff /ipatests/test_xmlrpc/tracker | |
| parent | dbc3a7511029dd954fff4cdb722f51e1f4e4b054 (diff) | |
| download | freeipa-fe2ce02a6f7664e377c367e16e9c2e1ad960c9d7.tar.gz freeipa-fe2ce02a6f7664e377c367e16e9c2e1ad960c9d7.tar.xz freeipa-fe2ce02a6f7664e377c367e16e9c2e1ad960c9d7.zip | |
Performace: don't download password attributes in host/user-find
For each entry in user/host-find was executed an extra search for password
attributes what has significant impact on performance (for 2000 users
there were 2000 additional searches)
http://www.freeipa.org/page/V4/Performance_Improvements
https://fedorahosted.org/freeipa/ticket/5281
Reviewed-By: David Kupka <dkupka@redhat.com>
Diffstat (limited to 'ipatests/test_xmlrpc/tracker')
| -rw-r--r-- | ipatests/test_xmlrpc/tracker/host_plugin.py | 6 | ||||
| -rw-r--r-- | ipatests/test_xmlrpc/tracker/user_plugin.py | 8 |
2 files changed, 10 insertions, 4 deletions
diff --git a/ipatests/test_xmlrpc/tracker/host_plugin.py b/ipatests/test_xmlrpc/tracker/host_plugin.py index 0a69d39c0..67faa1acf 100644 --- a/ipatests/test_xmlrpc/tracker/host_plugin.py +++ b/ipatests/test_xmlrpc/tracker/host_plugin.py @@ -42,6 +42,8 @@ class HostTracker(Tracker): update_keys = retrieve_keys - {'dn'} managedby_keys = retrieve_keys - {'has_keytab', 'has_password'} allowedto_keys = retrieve_keys - {'has_keytab', 'has_password'} + find_keys = retrieve_keys - {'has_keytab', 'has_password'} + find_all_keys = retrieve_all_keys - {'has_keytab', 'has_password'} def __init__(self, name, fqdn=None, default_version=None): super(HostTracker, self).__init__(default_version=default_version) @@ -136,9 +138,9 @@ class HostTracker(Tracker): def check_find(self, result, all=False, raw=False): """Check `host_find` command result""" if all: - expected = self.filter_attrs(self.retrieve_all_keys) + expected = self.filter_attrs(self.find_all_keys) else: - expected = self.filter_attrs(self.retrieve_keys) + expected = self.filter_attrs(self.find_keys) assert_deepequal(dict( count=1, truncated=False, diff --git a/ipatests/test_xmlrpc/tracker/user_plugin.py b/ipatests/test_xmlrpc/tracker/user_plugin.py index 216112db5..5acfc63cd 100644 --- a/ipatests/test_xmlrpc/tracker/user_plugin.py +++ b/ipatests/test_xmlrpc/tracker/user_plugin.py @@ -51,8 +51,12 @@ class UserTracker(Tracker): update_keys = retrieve_keys - {u'dn'} activate_keys = retrieve_keys - find_keys = retrieve_keys - {u'mepmanagedentry', u'memberof_group'} - find_all_keys = retrieve_all_keys + find_keys = retrieve_keys - { + u'mepmanagedentry', u'memberof_group', u'has_keytab', u'has_password' + } + find_all_keys = retrieve_all_keys - { + u'has_keytab', u'has_password' + } primary_keys = {u'uid', u'dn'} |