Remove unused variables in tests

This commit removes or marks unused variables as "expected to be unused"
by using '_' prefix.

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>

6 files changed, 5 insertions, 15 deletions

diff --git a/ipatests/test_webui/test_host.py b/ipatests/test_webui/test_host.py
index a87d50989..0fced0423 100644
--- a/ipatests/test_webui/test_host.py
+++ b/ipatests/test_webui/test_host.py
@@ -134,7 +134,6 @@ class test_host(host_tasks):
         self.init_app()
         # ENHANCEMENT: generate csr dynamically
         csr = self.load_file(csr_path)
-        realm = self.config.get('ipa_realm')
         cert_widget_sel = "div.certificate-widget"
 
         self.add_record(ENTITY, self.data)
@@ -229,7 +228,6 @@ class test_host(host_tasks):
 
         self.init_app()
         cert = self.load_file(cert_path)
-        realm = self.config.get('ipa_realm')
         self.add_record(ENTITY, self.data)
 
         self.navigate_to_record(self.pkey)
diff --git a/ipatests/test_webui/test_idviews.py b/ipatests/test_webui/test_idviews.py
index b7f5c312e..7e7d90564 100644
--- a/ipatests/test_webui/test_idviews.py
+++ b/ipatests/test_webui/test_idviews.py
@@ -106,7 +106,6 @@ class test_idviews(UI_driver):
 
         self.navigate_to_record(idview.PKEY)
         self.switch_to_facet(idview.HOST_FACET)
-        parent_entity = 'idview'
 
         # apply to host
         self.add_associations(
diff --git a/ipatests/test_webui/test_range.py b/ipatests/test_webui/test_range.py
index 35d2d60d9..bc0732510 100644
--- a/ipatests/test_webui/test_range.py
+++ b/ipatests/test_webui/test_range.py
@@ -59,9 +59,6 @@ class test_range(range_tasks):
 
         pkey_local = 'itest-local'
         pkey_ad = 'itest-ad'
-        pkey_posix = 'itest-ad-posix'
-        pkey_winsync = 'itest-ad-winsync'
-        pkey_trust = 'itest-ipa-trust'
         column = 'iparangetype'
 
         add = self.get_add_data(pkey_local)
diff --git a/ipatests/test_webui/test_service.py b/ipatests/test_webui/test_service.py
index 5b1849bae..602ae4d83 100644
--- a/ipatests/test_webui/test_service.py
+++ b/ipatests/test_webui/test_service.py
@@ -93,8 +93,6 @@ class test_service(sevice_tasks):
         data = self.prep_data()
         pkey = data.get('pkey')
         csr = self.load_file(csr_path)
-        host = self.config.get('ipa_server')
-        realm = self.config.get('ipa_realm')
         cert_widget_sel = "div.certificate-widget"
 
         self.add_record(ENTITY, data)
@@ -190,7 +188,6 @@ class test_service(sevice_tasks):
         data = self.prep_data()
         pkey = data.get('pkey')
         cert = self.load_file(cert_path)
-        realm = self.config.get('ipa_realm')
         cert_widget_sel = "div.certificate-widget"
 
         self.add_record(ENTITY, data)
diff --git a/ipatests/test_webui/test_user.py b/ipatests/test_webui/test_user.py
index a1fc7076a..c58e0eda1 100644
--- a/ipatests/test_webui/test_user.py
+++ b/ipatests/test_webui/test_user.py
@@ -190,7 +190,6 @@ class test_user(user_tasks):
         self.init_app()
         # ENHANCEMENT: generate csr dynamically
         csr = self.load_file(csr_path)
-        realm = self.config.get('ipa_realm')
         cert_widget_sel = "div.certificate-widget"
 
         self.add_record(user.ENTITY, user.DATA)
diff --git a/ipatests/test_webui/ui_driver.py b/ipatests/test_webui/ui_driver.py
index ab917d849..d581ad4a9 100644
--- a/ipatests/test_webui/ui_driver.py
+++ b/ipatests/test_webui/ui_driver.py
@@ -306,7 +306,7 @@ class UI_driver(object):
         """
         runner = self
 
-        for i in range(n):
+        for _i in range(n):
             self.wait(implicit)
             WebDriverWait(self.driver, self.request_timeout).until_not(lambda d: runner.has_active_request())
             self.wait()
@@ -1499,7 +1499,7 @@ class UI_driver(object):
 
         # add values
         for t in tables:
-            table, keys, exts = get_t_vals(t)
+            table, keys, _exts = get_t_vals(t)
             # add one by one to test for #3711
             for key in keys:
                 self.add_table_associations(table, [key])
@@ -1517,7 +1517,7 @@ class UI_driver(object):
         p = self.get_form()
         # now tables in categories should be empty, check it
         for t in tables:
-            table, keys, exts = get_t_vals(t)
+            table, keys, _exts = get_t_vals(t)
             if table in no_categories:
                 # clear the rest
                 self.delete_record(keys, None, p, table)
@@ -1534,7 +1534,7 @@ class UI_driver(object):
         self.assert_rule_tables_enabled(t_list, True)
 
         for t in tables:
-            table, keys, exts = get_t_vals(t)
+            table, keys, _exts = get_t_vals(t)
             # add multiple at once and test table delete button
             self.add_table_associations(table, keys, delete=True)
 
@@ -1678,7 +1678,7 @@ class UI_driver(object):
         """
         if not parent:
             parent = self.get_form()
-        el = self.find(selector, By.CSS_SELECTOR, parent, strict=True)
+        self.find(selector, By.CSS_SELECTOR, parent, strict=True)
         dis = self.find(selector+"[disabled]", By.CSS_SELECTOR, parent)
         if negative:
             assert dis is None, "Element is disabled: %s" % selector