summaryrefslogtreecommitdiffstats
path: root/ipaserver/install/dnskeysyncinstance.py
diff options
context:
space:
mode:
authorPetr Spacek <pspacek@redhat.com>2016-12-21 15:07:34 +0100
committerMartin Basti <mbasti@redhat.com>2017-01-06 09:26:56 +0100
commitfb7c111ac13510609e2cba14ecf88cd2ed291a4b (patch)
tree3c963ca45514bbd66706a27175726a19a9f87713 /ipaserver/install/dnskeysyncinstance.py
parent8db5b277a079fdfe5efbd7d49311f14489cee0e8 (diff)
downloadfreeipa-fb7c111ac13510609e2cba14ecf88cd2ed291a4b.tar.gz
freeipa-fb7c111ac13510609e2cba14ecf88cd2ed291a4b.tar.xz
freeipa-fb7c111ac13510609e2cba14ecf88cd2ed291a4b.zip
ipa_generate_password algorithm change
A change to the algorithm that generates random passwords for multiple purposes throught IPA. This spells out the need to assess password strength by the entropy it contains rather than its length. This new password generation should also be compatible with the NSS implementation of password requirements in FIPS environment so that newly created databases won't fail with wrong authentication. https://fedorahosted.org/freeipa/ticket/5695 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Petr Spacek <pspacek@redhat.com>
Diffstat (limited to 'ipaserver/install/dnskeysyncinstance.py')
-rw-r--r--ipaserver/install/dnskeysyncinstance.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/ipaserver/install/dnskeysyncinstance.py b/ipaserver/install/dnskeysyncinstance.py
index 76a14f9d9..861a1702e 100644
--- a/ipaserver/install/dnskeysyncinstance.py
+++ b/ipaserver/install/dnskeysyncinstance.py
@@ -224,10 +224,11 @@ class DNSKeySyncInstance(service.Service):
os.chown(paths.DNSSEC_TOKENS_DIR, self.ods_uid, self.named_gid)
# generate PINs for softhsm
- allowed_chars = u'123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'
pin_length = 30 # Bind allows max 32 bytes including ending '\0'
- pin = ipautil.ipa_generate_password(allowed_chars, pin_length)
- pin_so = ipautil.ipa_generate_password(allowed_chars, pin_length)
+ pin = ipautil.ipa_generate_password(
+ entropy_bits=0, special=None, min_len=pin_length)
+ pin_so = ipautil.ipa_generate_password(
+ entropy_bits=0, special=None, min_len=pin_length)
self.logger.debug("Saving user PIN to %s", paths.DNSSEC_SOFTHSM_PIN)
named_fd = open(paths.DNSSEC_SOFTHSM_PIN, 'w')