Pylint: enable check for unused-variables

Unused variables may:
* make code less readable
* create dead code
* potentialy hide issues/errors

Enabled check should prevent to leave unused variable in code

Check is locally disabled for modules that fix is not clear or easy or have too many occurences of
unused variables

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>

9 files changed, 18 insertions, 0 deletions

diff --git a/ipapython/certdb.py b/ipapython/certdb.py
index e19f712d8..850ba59bf 100644
--- a/ipapython/certdb.py
+++ b/ipapython/certdb.py
@@ -30,6 +30,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipapython import ipautil
 from ipalib import x509
 
+# pylint: disable=unused-variable
+
 CA_NICKNAME_FMT = "%s IPA CA"
 
 
diff --git a/ipapython/certmonger.py b/ipapython/certmonger.py
index 1f22fee3d..8c3faf029 100644
--- a/ipapython/certmonger.py
+++ b/ipapython/certmonger.py
@@ -34,6 +34,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipaplatform.paths import paths
 from ipaplatform import services
 
+# pylint: disable=unused-variable
+
 DBUS_CM_PATH = '/org/fedorahosted/certmonger'
 DBUS_CM_IF = 'org.fedorahosted.certmonger'
 DBUS_CM_NAME = 'org.fedorahosted.certmonger'
diff --git a/ipapython/cookie.py b/ipapython/cookie.py
index 89c3e3cd6..eaf6a37e7 100644
--- a/ipapython/cookie.py
+++ b/ipapython/cookie.py
@@ -27,6 +27,8 @@ from six.moves.urllib.parse import urlparse
 
 from ipapython.ipa_log_manager import log_mgr
 
+# pylint: disable=unused-variable
+
 '''
 Core Python has two cookie libraries, Cookie.py targeted to server
 side and cookielib.py targeted to client side. So why this module and
diff --git a/ipapython/dnssec/localhsm.py b/ipapython/dnssec/localhsm.py
index 8f18a45be..338adda0f 100755
--- a/ipapython/dnssec/localhsm.py
+++ b/ipapython/dnssec/localhsm.py
@@ -18,6 +18,8 @@ from ipapython.dnssec.abshsm import (attrs_name2id, attrs_id2name, AbstractHSM,
                                      keytype_id2name, keytype_name2id,
                                      ldap2p11helper_api_params)
 
+# pylint: disable=unused-variable
+
 private_key_api_params = set(["label", "id", "data", "unwrapping_key",
     "wrapping_mech", "key_type", "cka_always_authenticate", "cka_copyable",
     "cka_decrypt", "cka_derive", "cka_extractable", "cka_modifiable",
diff --git a/ipapython/install/core.py b/ipapython/install/core.py
index 8593690b3..98ee588d0 100644
--- a/ipapython/install/core.py
+++ b/ipapython/install/core.py
@@ -19,6 +19,8 @@ from ipapython.ipa_log_manager import root_logger
 from . import util
 from .util import from_
 
+# pylint: disable=unused-variable
+
 __all__ = ['InvalidStateError', 'KnobValueError', 'Property', 'Knob',
            'Configurable', 'Group', 'Component', 'Composite']
 
diff --git a/ipapython/ipaldap.py b/ipapython/ipaldap.py
index 704e71a94..2dfc5b350 100644
--- a/ipapython/ipaldap.py
+++ b/ipapython/ipaldap.py
@@ -44,6 +44,8 @@ from ipapython.dn import DN
 from ipapython.dnsutil import DNSName
 from ipapython.kerberos import Principal
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 
diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py
index 62d029d41..a7fd4edbb 100644
--- a/ipapython/ipautil.py
+++ b/ipapython/ipautil.py
@@ -54,6 +54,8 @@ from ipapython import config
 from ipaplatform.paths import paths
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 SHARE_DIR = paths.USR_SHARE_IPA_DIR
 PLUGINS_SHARE_DIR = paths.IPA_PLUGINS
 
diff --git a/ipapython/p11helper.py b/ipapython/p11helper.py
index 5ff9ccc4e..0001b6a34 100644
--- a/ipapython/p11helper.py
+++ b/ipapython/p11helper.py
@@ -12,6 +12,8 @@ from cryptography.hazmat.primitives import serialization
 from cryptography.hazmat.primitives.asymmetric import dsa, ec, rsa
 from cffi import FFI
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 
diff --git a/ipapython/sysrestore.py b/ipapython/sysrestore.py
index 1cc7ce56a..4e3cccb06 100644
--- a/ipapython/sysrestore.py
+++ b/ipapython/sysrestore.py
@@ -35,6 +35,8 @@ from six.moves.configparser import SafeConfigParser
 from ipaplatform.tasks import tasks
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str