install: fix command line option validation

The code which calls the validators was accidentally removed, re-add it.

https://fedorahosted.org/freeipa/ticket/5386
https://fedorahosted.org/freeipa/ticket/5391
https://fedorahosted.org/freeipa/ticket/5392

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>

1 files changed, 12 insertions, 1 deletions

diff --git a/ipapython/install/core.py b/ipapython/install/core.py
index 479149be6..8e3ba5802 100644
--- a/ipapython/install/core.py
+++ b/ipapython/install/core.py
@@ -118,6 +118,16 @@ class KnobBase(PropertyBase):
     def __init__(self, outer):
         self.outer = outer
 
+    def __set__(self, obj, value):
+        try:
+            self.validate(value)
+        except KnobValueError:
+            raise
+        except ValueError as e:
+            raise KnobValueError(self.__outer_name__, str(e))
+
+        super(KnobBase, self).__set__(obj, value)
+
     def validate(self, value):
         pass
 
@@ -243,7 +253,8 @@ class Configurable(six.with_metaclass(abc.ABCMeta, object)):
             except KeyError:
                 pass
             else:
-                setattr(self, name, value)
+                prop = prop_cls(self)
+                prop.__set__(self, value)
 
         if kwargs:
             extra = sorted(kwargs)