summaryrefslogtreecommitdiffstats
path: root/ipaplatform/base
diff options
context:
space:
mode:
authorJan Cholasta <jcholast@redhat.com>2017-02-14 09:58:44 +0100
committerMartin Basti <mbasti@redhat.com>2017-03-10 13:04:59 +0100
commit5d489ac5604ca959cfe439c0594b8739073f3cea (patch)
treec91df525969f3148ce300acb2912756fee385960 /ipaplatform/base
parent6027a8111fa9ed7a058fb222f4f96b12039deb8b (diff)
downloadfreeipa-5d489ac5604ca959cfe439c0594b8739073f3cea.tar.gz
freeipa-5d489ac5604ca959cfe439c0594b8739073f3cea.tar.xz
freeipa-5d489ac5604ca959cfe439c0594b8739073f3cea.zip
pylint_plugins: add forbidden import checker
Add new pylint AST checker plugin which implements a check for imports forbidden in IPA. Which imports are forbidden is configurable in pylintrc. Provide default forbidden import configuration and disable the check for existing forbidden imports in our code base. Reviewed-By: Martin Basti <mbasti@redhat.com>
Diffstat (limited to 'ipaplatform/base')
-rw-r--r--ipaplatform/base/services.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/ipaplatform/base/services.py b/ipaplatform/base/services.py
index 8149ff1ef..068b9723c 100644
--- a/ipaplatform/base/services.py
+++ b/ipaplatform/base/services.py
@@ -93,11 +93,13 @@ class PlatformService(object):
"""
def __init__(self, service_name, api=None):
+ # pylint: disable=ipa-forbidden-import
+ import ipalib # FixMe: break import cycle
+ # pylint: enable=ipa-forbidden-import
self.service_name = service_name
if api is not None:
self.api = api
else:
- import ipalib # FixMe: break import cycle
self.api = ipalib.api
warnings.warn(
"{s.__class__.__name__}('{s.service_name}', api=None) "